aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2018-12-10 10:38:49 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2018-12-10 10:38:49 -0500
commita628e0c5b484eed450093258440cf858bcdb0555 (patch)
treeae8b9218f640b954370d61f85b1639482f6efb6c
parentaedd3d4dbd6ecf73a4045e302b68cc498d0e6b58 (diff)
downloadpostgresql-a628e0c5b484eed450093258440cf858bcdb0555.tar.gz
postgresql-a628e0c5b484eed450093258440cf858bcdb0555.zip
Make TupleDescInitBuiltinEntry throw error for unsupported types.
Previously, it would just pass back a partially-uninitialized tupdesc, which doesn't seem like a safe or useful behavior. Backpatch to v10 where this code came in. Discussion: https://postgr.es/m/30830.1544384975@sss.pgh.pa.us
-rw-r--r--src/backend/access/common/tupdesc.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/access/common/tupdesc.c b/src/backend/access/common/tupdesc.c
index b0434b46720..852b96ebbbf 100644
--- a/src/backend/access/common/tupdesc.c
+++ b/src/backend/access/common/tupdesc.c
@@ -748,6 +748,9 @@ TupleDescInitBuiltinEntry(TupleDesc desc,
att->attstorage = 'p';
att->attcollation = InvalidOid;
break;
+
+ default:
+ elog(ERROR, "unsupported type %u", oidtypeid);
}
}