diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2012-08-27 12:45:51 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2012-08-27 12:45:51 -0400 |
| commit | a6f43529ea6c3abd9207cea140ab231ac078746a (patch) | |
| tree | 24d1e68b9cfa529cb4f67adc41cd063473793e9c | |
| parent | 81bcc8bc4ca6335f0b5b2029ebe84fbd788556fe (diff) | |
| download | postgresql-a6f43529ea6c3abd9207cea140ab231ac078746a.tar.gz postgresql-a6f43529ea6c3abd9207cea140ab231ac078746a.zip | |
Fix DROP INDEX CONCURRENTLY IF EXISTS.
This threw ERROR, not the expected NOTICE, if the index didn't exist.
The bug was actually visible in not-as-expected regression test output,
so somebody wasn't paying too close attention in commit
8cb53654dbdb4c386369eb988062d0bbb6de725e.
Per report from Brendan Byrd.
| -rw-r--r-- | src/backend/parser/gram.y | 2 | ||||
| -rw-r--r-- | src/test/regress/expected/create_index.out | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y index 7120b1e3187..44d0b3c6000 100644 --- a/src/backend/parser/gram.y +++ b/src/backend/parser/gram.y @@ -4854,7 +4854,7 @@ DropStmt: DROP drop_type IF_P EXISTS any_name_list opt_drop_behavior { DropStmt *n = makeNode(DropStmt); n->removeType = OBJECT_INDEX; - n->missing_ok = FALSE; + n->missing_ok = TRUE; n->objects = $6; n->arguments = NIL; n->behavior = $7; diff --git a/src/test/regress/expected/create_index.out b/src/test/regress/expected/create_index.out index 1f27b8e75f6..999e38a6798 100644 --- a/src/test/regress/expected/create_index.out +++ b/src/test/regress/expected/create_index.out @@ -2321,7 +2321,7 @@ Indexes: -- DROP INDEX CONCURRENTLY "concur_index2"; -- works DROP INDEX CONCURRENTLY IF EXISTS "concur_index2"; -- notice -ERROR: index "concur_index2" does not exist +NOTICE: index "concur_index2" does not exist, skipping -- failures DROP INDEX CONCURRENTLY "concur_index2", "concur_index3"; ERROR: DROP INDEX CONCURRENTLY does not support dropping multiple objects |