diff options
| author | Tomas Vondra <tomas.vondra@postgresql.org> | 2021-09-21 01:13:11 +0200 |
|---|---|---|
| committer | Tomas Vondra <tomas.vondra@postgresql.org> | 2021-09-23 18:25:37 +0200 |
| commit | abb2f9144ba1b7ac806f3779f53ae2f6174cd2d9 (patch) | |
| tree | dfc4a0b23a8e84e98b024888fd9f6eedd3d26030 | |
| parent | bb7628e55eda6f450f0f824d11c9a34b11f6bb12 (diff) | |
| download | postgresql-abb2f9144ba1b7ac806f3779f53ae2f6174cd2d9.tar.gz postgresql-abb2f9144ba1b7ac806f3779f53ae2f6174cd2d9.zip | |
Release memory allocated by dependency_degree
Calculating degree of a functional dependency may allocate a lot of
memory - we have released mot of the explicitly allocated memory, but
e.g. detoasted varlena values were left behind. That may be an issue,
because we consider a lot of dependencies (all combinations), and the
detoasting may happen for each one again.
Fixed by calling dependency_degree() in a dedicated context, and
resetting it after each call. We only need the calculated dependency
degree, so we don't need to copy anything.
Backpatch to PostgreSQL 10, where extended statistics were introduced.
Backpatch-through: 10
Discussion: https://www.postgresql.org/message-id/20210915200928.GP831%40telsasoft.com
| -rw-r--r-- | src/backend/statistics/dependencies.c | 22 |
1 files changed, 16 insertions, 6 deletions
diff --git a/src/backend/statistics/dependencies.c b/src/backend/statistics/dependencies.c index d703e9b9ba1..8bf80db8e4d 100644 --- a/src/backend/statistics/dependencies.c +++ b/src/backend/statistics/dependencies.c @@ -30,6 +30,7 @@ #include "utils/fmgroids.h" #include "utils/fmgrprotos.h" #include "utils/lsyscache.h" +#include "utils/memutils.h" #include "utils/selfuncs.h" #include "utils/syscache.h" #include "utils/typcache.h" @@ -325,12 +326,6 @@ dependency_degree(StatsBuildData *data, int k, AttrNumber *dependency) group_size++; } - if (items) - pfree(items); - - pfree(mss); - pfree(attnums_dep); - /* Compute the 'degree of validity' as (supporting/total). */ return (n_supporting_rows * 1.0 / data->numrows); } @@ -359,9 +354,15 @@ statext_dependencies_build(StatsBuildData *data) /* result */ MVDependencies *dependencies = NULL; + MemoryContext cxt; Assert(data->nattnums >= 2); + /* tracks memory allocated by dependency_degree calls */ + cxt = AllocSetContextCreate(CurrentMemoryContext, + "dependency_degree cxt", + ALLOCSET_DEFAULT_SIZES); + /* * We'll try build functional dependencies starting from the smallest ones * covering just 2 columns, to the largest ones, covering all columns @@ -380,10 +381,17 @@ statext_dependencies_build(StatsBuildData *data) { double degree; MVDependency *d; + MemoryContext oldcxt; + + /* release memory used by dependency degree calculation */ + oldcxt = MemoryContextSwitchTo(cxt); /* compute how valid the dependency seems */ degree = dependency_degree(data, k, dependency); + MemoryContextSwitchTo(oldcxt); + MemoryContextReset(cxt); + /* * if the dependency seems entirely invalid, don't store it */ @@ -425,6 +433,8 @@ statext_dependencies_build(StatsBuildData *data) DependencyGenerator_free(DependencyGenerator); } + MemoryContextDelete(cxt); + return dependencies; } |