diff options
| author | Noah Misch <noah@leadboat.com> | 2017-12-16 10:03:35 -0800 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2017-12-16 10:03:38 -0800 |
| commit | ac93acbc05be2ef995208c1ca17f8083f60ccc53 (patch) | |
| tree | e78d0d21a6e4ed041b62179c9962a6b4a02e1a87 | |
| parent | d3044f8b0732d369ad255c9268e2feb42acae2a0 (diff) | |
| download | postgresql-ac93acbc05be2ef995208c1ca17f8083f60ccc53.tar.gz postgresql-ac93acbc05be2ef995208c1ca17f8083f60ccc53.zip | |
Avoid and detect SIGPIPE race in TAP tests.
Don't write to stdin of a psql process that could have already exited
with an authentication failure. Buildfarm members crake and mandrill
have failed once by doing so. Ignore SIGPIPE in all TAP tests.
Back-patch to v10, where these tests were introduced.
Reviewed by Michael Paquier.
Discussion: https://postgr.es/m/20171209210203.GC3362632@rfd.leadboat.com
| -rw-r--r-- | src/test/authentication/t/001_password.pl | 3 | ||||
| -rw-r--r-- | src/test/authentication/t/002_saslprep.pl | 3 | ||||
| -rw-r--r-- | src/test/perl/TestLib.pm | 4 |
3 files changed, 6 insertions, 4 deletions
diff --git a/src/test/authentication/t/001_password.pl b/src/test/authentication/t/001_password.pl index 2d3f674144e..9340f2f1ab4 100644 --- a/src/test/authentication/t/001_password.pl +++ b/src/test/authentication/t/001_password.pl @@ -44,8 +44,7 @@ sub test_role $status_string = 'success' if ($expected_res eq 0); - my $res = - $node->psql('postgres', 'SELECT 1', extra_params => [ '-U', $role ]); + my $res = $node->psql('postgres', undef, extra_params => [ '-U', $role ]); is($res, $expected_res, "authentication $status_string for method $method, role $role"); } diff --git a/src/test/authentication/t/002_saslprep.pl b/src/test/authentication/t/002_saslprep.pl index df9f85d6a9f..e09273edd46 100644 --- a/src/test/authentication/t/002_saslprep.pl +++ b/src/test/authentication/t/002_saslprep.pl @@ -41,8 +41,7 @@ sub test_login $status_string = 'success' if ($expected_res eq 0); $ENV{"PGPASSWORD"} = $password; - my $res = - $node->psql('postgres', 'SELECT 1', extra_params => [ '-U', $role ]); + my $res = $node->psql('postgres', undef, extra_params => [ '-U', $role ]); is($res, $expected_res, "authentication $status_string for role $role with password $password" ); diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm index 6dba21c0736..141fec687cf 100644 --- a/src/test/perl/TestLib.pm +++ b/src/test/perl/TestLib.pm @@ -74,6 +74,10 @@ BEGIN INIT { + # Return EPIPE instead of killing the process with SIGPIPE. An affected + # test may still fail, but it's more likely to report useful facts. + $SIG{PIPE} = 'IGNORE'; + # Determine output directories, and create them. The base path is the # TESTDIR environment variable, which is normally set by the invoking # Makefile. |