diff options
| author | Noah Misch <noah@leadboat.com> | 2017-11-12 14:31:00 -0800 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2017-11-12 14:31:04 -0800 |
| commit | b2df91f2f38ebc46ab3dbda846c4278d6e67aa83 (patch) | |
| tree | 869834709a0fe29a4a5ceaf306d69629ac174b66 | |
| parent | d74db7a35c8dd18342fdf403375af55e2561e61e (diff) | |
| download | postgresql-b2df91f2f38ebc46ab3dbda846c4278d6e67aa83.tar.gz postgresql-b2df91f2f38ebc46ab3dbda846c4278d6e67aa83.zip | |
Install Windows crash dump handler before all else.
Apart from calling write_stderr() on failure, the handler depends on no
PostgreSQL facilities. We have experienced crashes before reaching the
former call site. Given such an early crash, this change cannot hurt
and may produce a helpful dump. Absent an early crash, this change has
no effect. Back-patch to 9.3 (all supported versions).
Takayuki Tsunakawa
Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CD13@G01JPEXMBYT05
| -rw-r--r-- | src/backend/main/main.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/backend/main/main.c b/src/backend/main/main.c index a1adb831099..de6f10feb77 100644 --- a/src/backend/main/main.c +++ b/src/backend/main/main.c @@ -61,6 +61,14 @@ main(int argc, char *argv[]) { bool do_check_root = true; + /* + * If supported on the current platform, set up a handler to be called if + * the backend/postmaster crashes with a fatal signal or exception. + */ +#if defined(WIN32) && defined(HAVE_MINIDUMP_TYPE) + pgwin32_install_crashdump_handler(); +#endif + progname = get_progname(argv[0]); /* @@ -82,14 +90,6 @@ main(int argc, char *argv[]) argv = save_ps_display_args(argc, argv); /* - * If supported on the current platform, set up a handler to be called if - * the backend/postmaster crashes with a fatal signal or exception. - */ -#if defined(WIN32) && defined(HAVE_MINIDUMP_TYPE) - pgwin32_install_crashdump_handler(); -#endif - - /* * Fire up essential subsystems: error and memory management * * Code after this point is allowed to use elog/ereport, though |