diff options
| author | Peter Geoghegan <pg@bowt.ie> | 2021-04-23 15:37:03 -0700 |
|---|---|---|
| committer | Peter Geoghegan <pg@bowt.ie> | 2021-04-23 15:37:03 -0700 |
| commit | bb3ecc8c961896ecb2ad3d5ba705c2877b933945 (patch) | |
| tree | 518f5a95cbf36a9df3c05e45771e08785deea50f | |
| parent | 82c3cd974131d7fa1cfcd07cebfb04fffe26ee35 (diff) | |
| download | postgresql-bb3ecc8c961896ecb2ad3d5ba705c2877b933945.tar.gz postgresql-bb3ecc8c961896ecb2ad3d5ba705c2877b933945.zip | |
amcheck: MAXALIGN() nbtree special area offset.
This isn't strictly necessary, but in theory it might matter if in the
future the width of the nbtree special area changes -- its total size
might not be an even number of MAXALIGN() quantums, even with padding.
PageInit() MAXALIGN()s all special area offsets, but amcheck uses the
offset to perform initial basic validation of line pointers, so we don't
rely on the offset from the page header.
The real reason to do this is to set a good example for new code that
adds amcheck coverage for other index AMs.
Reported-By: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Discussion: https://postgr.es/m/CALj2ACUMqTR9nErh99FbOBmzCXE9=gXNqhBiwYOhejJJS1LXqQ@mail.gmail.com
| -rw-r--r-- | contrib/amcheck/verify_nbtree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c index 3d06be55632..2c1d5f81a88 100644 --- a/contrib/amcheck/verify_nbtree.c +++ b/contrib/amcheck/verify_nbtree.c @@ -3134,7 +3134,7 @@ PageGetItemIdCareful(BtreeCheckState *state, BlockNumber block, Page page, ItemId itemid = PageGetItemId(page, offset); if (ItemIdGetOffset(itemid) + ItemIdGetLength(itemid) > - BLCKSZ - sizeof(BTPageOpaqueData)) + BLCKSZ - MAXALIGN(sizeof(BTPageOpaqueData))) ereport(ERROR, (errcode(ERRCODE_INDEX_CORRUPTED), errmsg("line pointer points past end of tuple space in index \"%s\"", |