diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2014-03-16 23:22:21 -0300 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2014-03-16 23:22:21 -0300 |
| commit | bd1154edec5484390d7dcd05d12287ccc81c30e8 (patch) | |
| tree | 421e7a165cca603962f54acd0b489c4212730ab0 | |
| parent | 0268d21e5d3c732bf5543d68a6d870e4eee7e673 (diff) | |
| download | postgresql-bd1154edec5484390d7dcd05d12287ccc81c30e8.tar.gz postgresql-bd1154edec5484390d7dcd05d12287ccc81c30e8.zip | |
plperl: Fix memory leak in hek2cstr
Backpatch all the way back to 9.1, where it was introduced by commit
50d89d42.
Reported by Sergey Burladyan in #9223
Author: Alex Hunsaker
| -rw-r--r-- | src/pl/plperl/plperl.c | 20 |
1 files changed, 18 insertions, 2 deletions
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c index e91b71e7779..7bc29a6b324 100644 --- a/src/pl/plperl/plperl.c +++ b/src/pl/plperl/plperl.c @@ -308,6 +308,16 @@ static char *setlocale_perl(int category, char *locale); static char * hek2cstr(HE *he) { + char *ret; + SV *sv; + + /* + * HeSVKEY_force will return a temporary mortal SV*, so we need to make + * sure to free it with ENTER/SAVE/FREE/LEAVE + */ + ENTER; + SAVETMPS; + /*------------------------- * Unfortunately, while HeUTF8 is true for most things > 256, for values * 128..255 it's not, but perl will treat them as unicode code points if @@ -332,11 +342,17 @@ hek2cstr(HE *he) * right thing *------------------------- */ - SV *sv = HeSVKEY_force(he); + sv = HeSVKEY_force(he); if (HeUTF8(he)) SvUTF8_on(sv); - return sv2cstr(sv); + ret = sv2cstr(sv); + + /* free sv */ + FREETMPS; + LEAVE; + + return ret; } /* |