diff options
| author | Nathan Bossart <nathan@postgresql.org> | 2023-11-15 15:04:18 -0600 |
|---|---|---|
| committer | Nathan Bossart <nathan@postgresql.org> | 2023-11-15 15:04:47 -0600 |
| commit | c23677844c96ead2f3ee8183a2ab3dd67f7862a0 (patch) | |
| tree | 31b55b18594ea8eed124ff29fae025bacd812008 | |
| parent | e43790342be29addaa843b80e8f58334fe7346d3 (diff) | |
| download | postgresql-c23677844c96ead2f3ee8183a2ab3dd67f7862a0.tar.gz postgresql-c23677844c96ead2f3ee8183a2ab3dd67f7862a0.zip | |
Fix fallback implementation for pg_atomic_test_set_flag().
The fallback implementation of pg_atomic_test_set_flag() that uses
atomic-exchange gives pg_atomic_exchange_u32_impl() an extra
argument. This issue has been present since the introduction of
the atomics API in commit b64d92f1a5.
Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/20231114035439.GA1809032%40nathanxps13
Backpatch-through: 12
| -rw-r--r-- | src/include/port/atomics/generic.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/port/atomics/generic.h b/src/include/port/atomics/generic.h index 33cb0cface5..ad7d1624c8b 100644 --- a/src/include/port/atomics/generic.h +++ b/src/include/port/atomics/generic.h @@ -83,7 +83,7 @@ pg_atomic_init_flag_impl(volatile pg_atomic_flag *ptr) static inline bool pg_atomic_test_set_flag_impl(volatile pg_atomic_flag *ptr) { - return pg_atomic_exchange_u32_impl(ptr, &value, 1) == 0; + return pg_atomic_exchange_u32_impl(ptr, 1) == 0; } #define PG_HAVE_ATOMIC_UNLOCKED_TEST_FLAG |