aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2021-03-31 16:45:17 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2021-03-31 16:45:24 -0400
commitc545e9524dcfcfce25c370f584b31562e8d7a4b7 (patch)
treee28e8200d66b36f34b20d7e69a5cb4e28a12a2fc
parent3b0c647bbfc52894d979976f1e6d60e40649bba7 (diff)
downloadpostgresql-c545e9524dcfcfce25c370f584b31562e8d7a4b7.tar.gz
postgresql-c545e9524dcfcfce25c370f584b31562e8d7a4b7.zip
Don't prematurely cram a value into a short int.
Since a4d75c86b, some buildfarm members have been warning that Assert(attnum <= MaxAttrNumber); is useless if attnum is an AttrNumber. I'm not certain how plausible it is that the value coming out of the bitmap could actually exceed MaxAttrNumber, but we seem to have thought that that was possible back in 7300a6995. Revert the intermediate variable to int so that we have the same overflow protection as before.
-rw-r--r--src/backend/statistics/extended_stats.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c
index 8c75690fce8..dd3c84a91c0 100644
--- a/src/backend/statistics/extended_stats.c
+++ b/src/backend/statistics/extended_stats.c
@@ -978,7 +978,7 @@ build_attnums_array(Bitmapset *attrs, int nexprs, int *numattrs)
j = -1;
while ((j = bms_next_member(attrs, j)) >= 0)
{
- AttrNumber attnum = (j - nexprs);
+ int attnum = (j - nexprs);
/*
* Make sure the bitmap contains only user-defined attributes. As