diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2020-09-24 09:26:09 +1200 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2020-09-24 10:31:57 +1200 |
| commit | c5a5bd0bb6ffaaf2ea14dba37b578412523071c8 (patch) | |
| tree | 2f4b259dcf3f243fb94803d232a18ec342602a4d | |
| parent | c1f63c42fc1393bdf4ff2acc7d5cf629871538cc (diff) | |
| download | postgresql-c5a5bd0bb6ffaaf2ea14dba37b578412523071c8.tar.gz postgresql-c5a5bd0bb6ffaaf2ea14dba37b578412523071c8.zip | |
Fix missing fsync of SLRU directories.
Harmonize behavior by moving reponsibility for fsyncing directories down
into slru.c. In 10 and later, only the multixact directories were
missed (see commit 1b02be21), and in older branches all SLRUs were
missed.
Back-patch to all supported releases.
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/CA%2BhUKGLtsTUOScnNoSMZ-2ZLv%2BwGh01J6kAo_DM8mTRq1sKdSQ%40mail.gmail.com
| -rw-r--r-- | src/backend/access/transam/clog.c | 7 | ||||
| -rw-r--r-- | src/backend/access/transam/commit_ts.c | 6 | ||||
| -rw-r--r-- | src/backend/access/transam/slru.c | 4 |
3 files changed, 4 insertions, 13 deletions
diff --git a/src/backend/access/transam/clog.c b/src/backend/access/transam/clog.c index 501bc20a96a..a8d1080f175 100644 --- a/src/backend/access/transam/clog.c +++ b/src/backend/access/transam/clog.c @@ -837,13 +837,6 @@ CheckPointCLOG(void) /* Flush dirty CLOG pages to disk */ TRACE_POSTGRESQL_CLOG_CHECKPOINT_START(true); SimpleLruFlush(ClogCtl, true); - - /* - * fsync pg_xact to ensure that any files flushed previously are durably - * on disk. - */ - fsync_fname("pg_xact", true); - TRACE_POSTGRESQL_CLOG_CHECKPOINT_DONE(true); } diff --git a/src/backend/access/transam/commit_ts.c b/src/backend/access/transam/commit_ts.c index 599203c96ce..6c4911d9bcf 100644 --- a/src/backend/access/transam/commit_ts.c +++ b/src/backend/access/transam/commit_ts.c @@ -761,12 +761,6 @@ CheckPointCommitTs(void) { /* Flush dirty CommitTs pages to disk */ SimpleLruFlush(CommitTsCtl, true); - - /* - * fsync pg_commit_ts to ensure that any files flushed previously are - * durably on disk. - */ - fsync_fname("pg_commit_ts", true); } /* diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.c index 67387979bdb..cfe95138275 100644 --- a/src/backend/access/transam/slru.c +++ b/src/backend/access/transam/slru.c @@ -1159,6 +1159,10 @@ SimpleLruFlush(SlruCtl ctl, bool allow_redirtied) } if (!ok) SlruReportIOError(ctl, pageno, InvalidTransactionId); + + /* Ensure that directory entries for new files are on disk. */ + if (ctl->do_fsync) + fsync_fname(ctl->Dir, true); } /* |