diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-10-06 12:20:13 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-10-06 12:20:13 -0400 |
| commit | c7c93dd55af5d15e22a7343f15fdf917f61304fb (patch) | |
| tree | 435fc2727a7b5e250b1888f078f48c26d0fd9b96 | |
| parent | fc0df3bdafd68c652999c59b5f56d07ef2fd9c25 (diff) | |
| download | postgresql-c7c93dd55af5d15e22a7343f15fdf917f61304fb.tar.gz postgresql-c7c93dd55af5d15e22a7343f15fdf917f61304fb.zip | |
Fix access-off-end-of-array in clog.c.
Sloppy loop coding in set_status_by_pages() resulted in fetching one array
element more than it should from the subxids[] array. The odds of this
resulting in SIGSEGV are pretty small, but we've certainly seen that happen
with similar mistakes elsewhere. While at it, we can get rid of an extra
TransactionIdToPage() calculation per loop.
Per report from David Binderman. Back-patch to all supported branches,
since this code is quite old.
Discussion: https://postgr.es/m/HE1PR0802MB2331CBA919CBFFF0C465EB429C710@HE1PR0802MB2331.eurprd08.prod.outlook.com
| -rw-r--r-- | src/backend/access/transam/clog.c | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/src/backend/access/transam/clog.c b/src/backend/access/transam/clog.c index 3a58f1ed811..50c55db4437 100644 --- a/src/backend/access/transam/clog.c +++ b/src/backend/access/transam/clog.c @@ -226,21 +226,27 @@ set_status_by_pages(int nsubxids, TransactionId *subxids, int offset = 0; int i = 0; + Assert(nsubxids > 0); /* else the pageno fetch above is unsafe */ + while (i < nsubxids) { int num_on_page = 0; + int nextpageno; - while (TransactionIdToPage(subxids[i]) == pageno && i < nsubxids) + do { + nextpageno = TransactionIdToPage(subxids[i]); + if (nextpageno != pageno) + break; num_on_page++; i++; - } + } while (i < nsubxids); TransactionIdSetPageStatus(InvalidTransactionId, num_on_page, subxids + offset, status, lsn, pageno); offset = i; - pageno = TransactionIdToPage(subxids[offset]); + pageno = nextpageno; } } |