diff options
| author | Fujii Masao <fujii@postgresql.org> | 2020-06-02 19:18:13 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2020-06-02 19:21:04 +0900 |
| commit | caa3c4242cf86322e2ed0c86199e6462a2c41565 (patch) | |
| tree | 37c398265073850ae31a63241b4465114f2dc1e0 | |
| parent | e641b2a995abfa0dd7039863e2597feb3abf2b1e (diff) | |
| download | postgresql-caa3c4242cf86322e2ed0c86199e6462a2c41565.tar.gz postgresql-caa3c4242cf86322e2ed0c86199e6462a2c41565.zip | |
Don't call elog() while holding spinlock.
Previously UpdateSpillStats() called elog(DEBUG2) while holding
the spinlock even though the local variables that the elog() accesses
don't need to be protected by the lock. Since spinlocks are intended
for very short-term locks, they should not be used when calling
elog(DEBUG2). So this commit moves that elog() out of spinlock period.
Author: Kyotaro Horiguchi
Reviewed-by: Amit Kapila and Fujii Masao
Discussion: https://postgr.es/m/20200602.161518.1399689010416646074.horikyota.ntt@gmail.com
| -rw-r--r-- | src/backend/replication/walsender.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index 86847cbb54f..2364cbfc61b 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -3685,17 +3685,15 @@ UpdateSpillStats(LogicalDecodingContext *ctx) { ReorderBuffer *rb = ctx->reorder; - SpinLockAcquire(&MyWalSnd->mutex); - - MyWalSnd->spillTxns = rb->spillTxns; - MyWalSnd->spillCount = rb->spillCount; - MyWalSnd->spillBytes = rb->spillBytes; - elog(DEBUG2, "UpdateSpillStats: updating stats %p %lld %lld %lld", rb, (long long) rb->spillTxns, (long long) rb->spillCount, (long long) rb->spillBytes); + SpinLockAcquire(&MyWalSnd->mutex); + MyWalSnd->spillTxns = rb->spillTxns; + MyWalSnd->spillCount = rb->spillCount; + MyWalSnd->spillBytes = rb->spillBytes; SpinLockRelease(&MyWalSnd->mutex); } |