aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Gustafsson <dgustafsson@postgresql.org>2024-01-17 11:24:11 +0100
committerDaniel Gustafsson <dgustafsson@postgresql.org>2024-01-17 11:24:11 +0100
commitdb0d238419decf7edfd84b24d1a151b3ac21dc6a (patch)
tree3297ce86f25b0d17dfc50b0de1edd1970fa2c081
parentd29a4fbacfb7998df16b6fabcd33400a5ae07c43 (diff)
downloadpostgresql-db0d238419decf7edfd84b24d1a151b3ac21dc6a.tar.gz
postgresql-db0d238419decf7edfd84b24d1a151b3ac21dc6a.zip
Close socket in case of errors in setting non-blocking
If configuring the newly created socket non-blocking fails we error out and return INVALID_SOCKET, but the socket that had been created wasn't closed. Fix by issuing closesocket in the errorpath. Backpatch to all supported branches. Author: Ranier Vilela <ranier.vf@gmail.com> Discussion: https://postgr.es/m/CAEudQApmU5CrKefH85VbNYE2y8H=-qqEJbg6RAPU65+vCe+89A@mail.gmail.com Backpatch-through: v12
-rw-r--r--src/backend/port/win32/socket.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/backend/port/win32/socket.c b/src/backend/port/win32/socket.c
index d5b5e771e91..2fcfc68a315 100644
--- a/src/backend/port/win32/socket.c
+++ b/src/backend/port/win32/socket.c
@@ -290,6 +290,7 @@ pgwin32_socket(int af, int type, int protocol)
if (ioctlsocket(s, FIONBIO, &on))
{
TranslateSocketError();
+ closesocket(s);
return INVALID_SOCKET;
}
errno = 0;