diff options
| author | Andrew Dunstan <andrew@dunslane.net> | 2024-07-12 18:29:15 -0400 |
|---|---|---|
| committer | Andrew Dunstan <andrew@dunslane.net> | 2024-07-13 08:08:07 -0400 |
| commit | dd12eb33aff94dabee03d32a98d80dfa434805a6 (patch) | |
| tree | c85bd02d69c8db690cb89e35350c0247c7f29d7c | |
| parent | 3c1c82d4066e19a2841fb5f0529452de0d4d65b2 (diff) | |
| download | postgresql-dd12eb33aff94dabee03d32a98d80dfa434805a6.tar.gz postgresql-dd12eb33aff94dabee03d32a98d80dfa434805a6.zip | |
Make sure to run pg_isready on correct port
The current code can have pg_isready unexpectedly succeed if there is a
server running on the default port. To avoid this we delay running the
test until after a node has been created but before it starts, and then
use that node's port, so we are fairly sure there is nothing running on
the port.
Backpatch to all live branches.
| -rw-r--r-- | src/bin/scripts/t/080_pg_isready.pl | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/bin/scripts/t/080_pg_isready.pl b/src/bin/scripts/t/080_pg_isready.pl index fba3018175f..dd64502e696 100644 --- a/src/bin/scripts/t/080_pg_isready.pl +++ b/src/bin/scripts/t/080_pg_isready.pl @@ -12,10 +12,11 @@ program_help_ok('pg_isready'); program_version_ok('pg_isready'); program_options_handling_ok('pg_isready'); -command_fails(['pg_isready'], 'fails with no server running'); - my $node = PostgreSQL::Test::Cluster->new('main'); $node->init; + +$node->command_fails(['pg_isready'], 'fails with no server running'); + $node->start; $node->command_ok( |