diff options
| author | Michael Paquier <michael@paquier.xyz> | 2023-09-04 14:55:53 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2023-09-04 14:55:53 +0900 |
| commit | df11421d8242dd13b2b734d7f2ff65aff7619b85 (patch) | |
| tree | 82d97b666f26ab9bea7c4dda0aaac25be92bcd70 | |
| parent | b8f4644d60f5ce6c9ff28e9d76ab104818053379 (diff) | |
| download | postgresql-df11421d8242dd13b2b734d7f2ff65aff7619b85.tar.gz postgresql-df11421d8242dd13b2b734d7f2ff65aff7619b85.zip | |
Fix out-of-bound read in gtsvector_picksplit()
This could lead to an imprecise choice when splitting an index page of a
GiST index on a tsvector, deciding which entries should remain on the
old page and which entries should move to a new page.
This is wrong since tsearch2 has been moved into core with commit
140d4ebcb46e, so backpatch all the way down. This error has been
spotted by valgrind.
Author: Alexander Lakhin
Discussion: https://postgr.es/m/17950-6c80a8d2b94ec695@postgresql.org
Backpatch-through: 11
| -rw-r--r-- | src/backend/utils/adt/tsgistidx.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/utils/adt/tsgistidx.c b/src/backend/utils/adt/tsgistidx.c index c09eefdda23..157cc4536bd 100644 --- a/src/backend/utils/adt/tsgistidx.c +++ b/src/backend/utils/adt/tsgistidx.c @@ -728,7 +728,7 @@ gtsvector_picksplit(PG_FUNCTION_ARGS) size_alpha = SIGLENBIT(siglen) - sizebitvec((cache[j].allistrue) ? GETSIGN(datum_l) : - GETSIGN(cache[j].sign), + cache[j].sign, siglen); } else @@ -742,7 +742,7 @@ gtsvector_picksplit(PG_FUNCTION_ARGS) size_beta = SIGLENBIT(siglen) - sizebitvec((cache[j].allistrue) ? GETSIGN(datum_r) : - GETSIGN(cache[j].sign), + cache[j].sign, siglen); } else |