diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2023-04-20 18:12:32 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2023-04-20 18:12:32 -0400 |
| commit | e2e34dfff5e75ee52655053e94ad2acd51335d81 (patch) | |
| tree | f7b842adc8f91172287fba8c1fb08faea1c88994 | |
| parent | 2ad35cf06752f810d113cfd49eb9fba3f80a3491 (diff) | |
| download | postgresql-e2e34dfff5e75ee52655053e94ad2acd51335d81.tar.gz postgresql-e2e34dfff5e75ee52655053e94ad2acd51335d81.zip | |
Use --strip-unneeded when stripping static libraries with GNU strip.
We've long used "--strip-unneeded" for shared libraries but plain
"-x" for static libraries when stripping symbols with GNU strip.
There doesn't seem to be any really good reason for that though,
since --strip-unneeded produces smaller output (as "-x" alone
does not remove debug symbols). Moreover it seems that
llvm-strip, although it identifies as GNU strip, misbehaves when
given "-x" for this purpose. It's unclear whether that's
intentional or a bug in llvm-strip, but in any case it seems like
changing to use --strip-unneeded in all cases should be a win.
Note that this doesn't change our behavior when dealing with
non-GNU strip.
Per gripes from Ed Maste and Palle Girgensohn. Back-patch,
in case anyone wants to use llvm-strip with stable branches.
Discussion: https://postgr.es/m/17898-5308d09543463266@postgresql.org
Discussion: https://postgr.es/m/20230420153338.bbj2g5jiyy3afhjz@awork3.anarazel.de
| -rw-r--r-- | config/programs.m4 | 2 | ||||
| -rwxr-xr-x | configure | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/config/programs.m4 b/config/programs.m4 index 5a1859fd139..3b477c7f74e 100644 --- a/config/programs.m4 +++ b/config/programs.m4 @@ -271,7 +271,7 @@ AC_DEFUN([PGAC_CHECK_STRIP], AC_MSG_CHECKING([whether it is possible to strip libraries]) if test x"$STRIP" != x"" && "$STRIP" -V 2>&1 | grep "GNU strip" >/dev/null; then - STRIP_STATIC_LIB="$STRIP -x" + STRIP_STATIC_LIB="$STRIP --strip-unneeded" STRIP_SHARED_LIB="$STRIP --strip-unneeded" AC_MSG_RESULT(yes) else diff --git a/configure b/configure index 7b97a409a8e..cae53aa76b9 100755 --- a/configure +++ b/configure @@ -9261,7 +9261,7 @@ fi { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether it is possible to strip libraries" >&5 $as_echo_n "checking whether it is possible to strip libraries... " >&6; } if test x"$STRIP" != x"" && "$STRIP" -V 2>&1 | grep "GNU strip" >/dev/null; then - STRIP_STATIC_LIB="$STRIP -x" + STRIP_STATIC_LIB="$STRIP --strip-unneeded" STRIP_SHARED_LIB="$STRIP --strip-unneeded" { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 $as_echo "yes" >&6; } |