diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-12-11 16:33:20 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-12-11 16:33:33 -0500 |
| commit | e3d194f74a15417cc6a30b021b87ee836c8544f3 (patch) | |
| tree | a245f799312fb5567c831feeabd52013657501b6 | |
| parent | 22e71b3afb1c3bc994ba71a8c41784ddec53ceda (diff) | |
| download | postgresql-e3d194f74a15417cc6a30b021b87ee836c8544f3.tar.gz postgresql-e3d194f74a15417cc6a30b021b87ee836c8544f3.zip | |
Fix corner-case coredump in _SPI_error_callback().
I noticed that _SPI_execute_plan initially sets spierrcontext.arg = NULL,
and only fills it in some time later. If an error were to happen in
between, _SPI_error_callback would try to dereference the null pointer.
This is unlikely --- there's not much between those points except
push-snapshot calls --- but it's clearly not impossible. Tweak the
callback to do nothing if the pointer isn't set yet.
It's been like this for awhile, so back-patch to all supported branches.
| -rw-r--r-- | src/backend/executor/spi.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c index 1069013cd2a..6d9dd9cc9f9 100644 --- a/src/backend/executor/spi.c +++ b/src/backend/executor/spi.c @@ -2365,6 +2365,9 @@ _SPI_error_callback(void *arg) const char *query = (const char *) arg; int syntaxerrposition; + if (query == NULL) /* in case arg wasn't set yet */ + return; + /* * If there is a syntax error position, convert to internal syntax error; * otherwise treat the query as an item of context stack |