diff options
| author | Michael Meskes <meskes@postgresql.org> | 2013-09-08 12:59:43 +0200 |
|---|---|---|
| committer | Michael Meskes <meskes@postgresql.org> | 2013-09-08 13:13:13 +0200 |
| commit | e8193088f12ecc221692af3cf5f51c782e815f46 (patch) | |
| tree | d40cd1b648f1dfc42afd17200c6dea9bbb4ea09c | |
| parent | 7612553e75f9ffb940b16a53004bec75f31803be (diff) | |
| download | postgresql-e8193088f12ecc221692af3cf5f51c782e815f46.tar.gz postgresql-e8193088f12ecc221692af3cf5f51c782e815f46.zip | |
Return error if allocation of new element was not possible.
Found by Coverity.
| -rw-r--r-- | src/interfaces/ecpg/pgtypeslib/numeric.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/interfaces/ecpg/pgtypeslib/numeric.c b/src/interfaces/ecpg/pgtypeslib/numeric.c index 7257c812542..55c5b45616e 100644 --- a/src/interfaces/ecpg/pgtypeslib/numeric.c +++ b/src/interfaces/ecpg/pgtypeslib/numeric.c @@ -430,14 +430,18 @@ PGTYPESnumeric_to_asc(numeric *num, int dscale) numeric *numcopy = PGTYPESnumeric_new(); char *s; - if (dscale < 0) - dscale = num->dscale; + if (numcopy == NULL) + return NULL; if (PGTYPESnumeric_copy(num, numcopy) < 0) { PGTYPESnumeric_free(numcopy); return NULL; } + + if (dscale < 0) + dscale = num->dscale; + /* get_str_from_var may change its argument */ s = get_str_from_var(numcopy, dscale); PGTYPESnumeric_free(numcopy); @@ -1520,6 +1524,9 @@ numericvar_to_double(numeric *var, double *dp) char *endptr; numeric *varcopy = PGTYPESnumeric_new(); + if (varcopy == NULL) + return -1; + if (PGTYPESnumeric_copy(var, varcopy) < 0) { PGTYPESnumeric_free(varcopy); |