aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndres Freund <andres@anarazel.de>2015-08-15 17:25:00 +0200
committerAndres Freund <andres@anarazel.de>2015-08-15 17:25:00 +0200
commite95126cf048b08d7ff5eb72ec33737e9e27c08f8 (patch)
tree1a02049f9cd86282a5cf6e9f6aa57c55c4906466
parentf9dec81a5493bc31fdbbf69b5fafe0d4452a38f1 (diff)
downloadpostgresql-e95126cf048b08d7ff5eb72ec33737e9e27c08f8.tar.gz
postgresql-e95126cf048b08d7ff5eb72ec33737e9e27c08f8.zip
Don't use function definitions looking like old-style ones.
This fixes a bunch of somewhat pedantic warnings with new compilers. Since by far the majority of other functions definitions use the (void) style it just seems to be consistent to do so as well in the remaining few places.
-rw-r--r--contrib/pg_standby/pg_standby.c2
-rw-r--r--src/backend/access/transam/twophase.c2
-rw-r--r--src/backend/commands/trigger.c2
-rw-r--r--src/backend/replication/logical/snapbuild.c2
-rw-r--r--src/backend/replication/repl_scanner.l2
-rw-r--r--src/backend/replication/walsender.c2
-rw-r--r--src/backend/storage/ipc/dsm_impl.c2
-rw-r--r--src/backend/utils/time/snapmgr.c2
-rw-r--r--src/bin/pg_resetxlog/pg_resetxlog.c2
-rw-r--r--src/pl/plperl/plperl.c2
10 files changed, 10 insertions, 10 deletions
diff --git a/contrib/pg_standby/pg_standby.c b/contrib/pg_standby/pg_standby.c
index 861caea3481..5eac2b1e490 100644
--- a/contrib/pg_standby/pg_standby.c
+++ b/contrib/pg_standby/pg_standby.c
@@ -171,7 +171,7 @@ CustomizableInitialize(void)
* Is the requested file ready yet?
*/
static bool
-CustomizableNextWALFileReady()
+CustomizableNextWALFileReady(void)
{
if (stat(WALFilePath, &stat_buf) == 0)
{
diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
index 177d1e1432e..d48d101340f 100644
--- a/src/backend/access/transam/twophase.c
+++ b/src/backend/access/transam/twophase.c
@@ -295,7 +295,7 @@ AtAbort_Twophase(void)
* PGXACT entry.
*/
void
-PostPrepare_Twophase()
+PostPrepare_Twophase(void)
{
LWLockAcquire(TwoPhaseStateLock, LW_EXCLUSIVE);
MyLockedGxact->locking_backend = InvalidBackendId;
diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
index 31091ba7f3e..d169027689a 100644
--- a/src/backend/commands/trigger.c
+++ b/src/backend/commands/trigger.c
@@ -3226,7 +3226,7 @@ static SetConstraintState SetConstraintStateAddItem(SetConstraintState state,
* Gets the current query fdw tuplestore and initializes it if necessary
*/
static Tuplestorestate *
-GetCurrentFDWTuplestore()
+GetCurrentFDWTuplestore(void)
{
Tuplestorestate *ret;
diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c
index efab4ca0df1..a574cf365a3 100644
--- a/src/backend/replication/logical/snapbuild.c
+++ b/src/backend/replication/logical/snapbuild.c
@@ -610,7 +610,7 @@ SnapBuildExportSnapshot(SnapBuild *builder)
* owner back to its original value.
*/
void
-SnapBuildClearExportedSnapshot()
+SnapBuildClearExportedSnapshot(void)
{
/* nothing exported, thats the usual case */
if (!ExportInProgress)
diff --git a/src/backend/replication/repl_scanner.l b/src/backend/replication/repl_scanner.l
index 056cc141293..91bac21b06b 100644
--- a/src/backend/replication/repl_scanner.l
+++ b/src/backend/replication/repl_scanner.l
@@ -237,7 +237,7 @@ replication_scanner_init(const char *str)
}
void
-replication_scanner_finish()
+replication_scanner_finish(void)
{
yy_delete_buffer(scanbufhandle);
scanbufhandle = NULL;
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
index e1bab079d5d..27de156b1ff 100644
--- a/src/backend/replication/walsender.c
+++ b/src/backend/replication/walsender.c
@@ -249,7 +249,7 @@ InitWalSender(void)
* process, similar to what transaction abort does in a regular backend.
*/
void
-WalSndErrorCleanup()
+WalSndErrorCleanup(void)
{
LWLockReleaseAll();
diff --git a/src/backend/storage/ipc/dsm_impl.c b/src/backend/storage/ipc/dsm_impl.c
index 0b10dac7290..921f0292e36 100644
--- a/src/backend/storage/ipc/dsm_impl.c
+++ b/src/backend/storage/ipc/dsm_impl.c
@@ -1027,7 +1027,7 @@ dsm_impl_pin_segment(dsm_handle handle, void *impl_private)
}
static int
-errcode_for_dynamic_shared_memory()
+errcode_for_dynamic_shared_memory(void)
{
if (errno == EFBIG || errno == ENOMEM)
return errcode(ERRCODE_OUT_OF_MEMORY);
diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c
index 2f0e9cda8c3..074935ce381 100644
--- a/src/backend/utils/time/snapmgr.c
+++ b/src/backend/utils/time/snapmgr.c
@@ -345,7 +345,7 @@ GetNonHistoricCatalogSnapshot(Oid relid)
* cycles we spent tracking such fine details would be well-spent.
*/
void
-InvalidateCatalogSnapshot()
+InvalidateCatalogSnapshot(void)
{
CatalogSnapshotStale = true;
}
diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
index 72755b064d5..b771a633179 100644
--- a/src/bin/pg_resetxlog/pg_resetxlog.c
+++ b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -703,7 +703,7 @@ PrintControlValues(bool guessed)
* Print the values to be changed.
*/
static void
-PrintNewControlValues()
+PrintNewControlValues(void)
{
char fname[MAXFNAMELEN];
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
index ae0ba19814f..296d17dbbb3 100644
--- a/src/pl/plperl/plperl.c
+++ b/src/pl/plperl/plperl.c
@@ -2993,7 +2993,7 @@ plperl_hash_from_tuple(HeapTuple tuple, TupleDesc tupdesc)
static void
-check_spi_usage_allowed()
+check_spi_usage_allowed(void)
{
/* see comment in plperl_fini() */
if (plperl_ending)