diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2005-10-12 17:18:03 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2005-10-12 17:18:03 +0000 |
| commit | e952ae1268c209a7685eb89b3269a18620509162 (patch) | |
| tree | 3c4f69c48319e028831766ccb3927b7956b9ea09 | |
| parent | fa72121594534dda6cc010f0bf6b3e8d22987526 (diff) | |
| download | postgresql-e952ae1268c209a7685eb89b3269a18620509162.tar.gz postgresql-e952ae1268c209a7685eb89b3269a18620509162.zip | |
Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark
the wrong buffer dirty when trying to kill a dead index entry that's on
a page after the one it started on. No risk of data corruption, just
inefficiency, but still a bug.
| -rw-r--r-- | src/backend/access/nbtree/nbtinsert.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c index 6e0b059ae13..c73ba358ec1 100644 --- a/src/backend/access/nbtree/nbtinsert.c +++ b/src/backend/access/nbtree/nbtinsert.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.125 2005/09/24 22:54:35 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.126 2005/10/12 17:18:03 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -261,7 +261,10 @@ _bt_check_unique(Relation rel, BTItem btitem, Relation heapRel, hbuffer) == HEAPTUPLE_DEAD) { curitemid->lp_flags |= LP_DELETE; - SetBufferCommitInfoNeedsSave(buf); + if (nbuf != InvalidBuffer) + SetBufferCommitInfoNeedsSave(nbuf); + else + SetBufferCommitInfoNeedsSave(buf); } LockBuffer(hbuffer, BUFFER_LOCK_UNLOCK); } |