diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-01-24 12:09:46 -0500 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-01-24 12:09:46 -0500 |
commit | ef9706bbc8ce917a366e4640df8c603c9605817a (patch) | |
tree | c77149b79355c4aa6f89d5784b8896c0c16c0d7c | |
parent | 1042de69dbb6f3c0aa92a741a68aeca23f4ed45e (diff) | |
download | postgresql-ef9706bbc8ce917a366e4640df8c603c9605817a.tar.gz postgresql-ef9706bbc8ce917a366e4640df8c603c9605817a.zip |
Remember to reset yy_start state when firing up repl_scanner.l.
Without this, we get odd behavior when the previous cycle of
lexing exited in a non-default exclusive state. Every other
copy of this code is aware that it has to do BEGIN(INITIAL),
but repl_scanner.l did not get that memo.
The real-world impact of this is probably limited, since most
replication clients would abandon their connection after getting
a syntax error. Still, it's a bug.
This mistake is old, so back-patch to all supported branches.
Discussion: https://postgr.es/m/1874781.1643035952@sss.pgh.pa.us
-rw-r--r-- | src/backend/replication/repl_scanner.l | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/replication/repl_scanner.l b/src/backend/replication/repl_scanner.l index dcc3c3fc515..02d025cd146 100644 --- a/src/backend/replication/repl_scanner.l +++ b/src/backend/replication/repl_scanner.l @@ -245,6 +245,9 @@ replication_scanner_init(const char *str) memcpy(scanbuf, str, slen); scanbuf[slen] = scanbuf[slen + 1] = YY_END_OF_BUFFER_CHAR; scanbufhandle = yy_scan_buffer(scanbuf, slen + 2); + + /* Make sure we start in proper state */ + BEGIN(INITIAL); } void |