aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2023-09-29 20:20:57 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2023-09-29 20:21:10 -0400
commitf02154652d1a83d80f4bee93b58ecdbd8c33378b (patch)
treed3ec8e31066fe744607ba7f97b3f29a0ce545fff
parent0cfc231aa19d80b31e37422a968d51fa8bcb53a9 (diff)
downloadpostgresql-f02154652d1a83d80f4bee93b58ecdbd8c33378b.tar.gz
postgresql-f02154652d1a83d80f4bee93b58ecdbd8c33378b.zip
Remove environment sensitivity in pl/tcl regression test.
Add "-gmt 1" to our test invocations of the Tcl "clock" command, so that they do not consult the timezone environment. While it doesn't really matter which timezone is used here, it does matter that the command not fall over entirely. We've now discovered that at least on FreeBSD, "clock scan" will fail if /etc/localtime is missing. It seems worth making the test insensitive to that. Per Tomas Vondras' buildfarm animal dikkop. Thanks to Thomas Munro for the diagnosis. Discussion: https://postgr.es/m/316d304a-1dcd-cea1-3d6c-27f794727a06@enterprisedb.com
-rw-r--r--src/pl/tcl/expected/pltcl_setup.out2
-rw-r--r--src/pl/tcl/sql/pltcl_setup.sql2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/pl/tcl/expected/pltcl_setup.out b/src/pl/tcl/expected/pltcl_setup.out
index ed809f02bfb..a8fdcf31256 100644
--- a/src/pl/tcl/expected/pltcl_setup.out
+++ b/src/pl/tcl/expected/pltcl_setup.out
@@ -119,7 +119,7 @@ CREATE OPERATOR CLASS tcl_int4_ops
-- for initialization problems.
--
create function tcl_date_week(int4,int4,int4) returns text as $$
- return [clock format [clock scan "$2/$3/$1"] -format "%U"]
+ return [clock format [clock scan "$2/$3/$1" -gmt 1] -format "%U" -gmt 1]
$$ language pltcl immutable;
select tcl_date_week(2010,1,26);
tcl_date_week
diff --git a/src/pl/tcl/sql/pltcl_setup.sql b/src/pl/tcl/sql/pltcl_setup.sql
index e9f59989b5b..b9892ea4f76 100644
--- a/src/pl/tcl/sql/pltcl_setup.sql
+++ b/src/pl/tcl/sql/pltcl_setup.sql
@@ -142,7 +142,7 @@ CREATE OPERATOR CLASS tcl_int4_ops
-- for initialization problems.
--
create function tcl_date_week(int4,int4,int4) returns text as $$
- return [clock format [clock scan "$2/$3/$1"] -format "%U"]
+ return [clock format [clock scan "$2/$3/$1" -gmt 1] -format "%U" -gmt 1]
$$ language pltcl immutable;
select tcl_date_week(2010,1,26);