aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2020-09-06 12:55:13 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2020-09-06 12:55:28 -0400
commitf04203ab7e683bc3e961a40b002cf3c8d1d12100 (patch)
tree271e29b693c3840c1067aeb8e6496ab917a0e1da
parente7f06ea60a3c07128176b294ce3fb0555edd15a5 (diff)
downloadpostgresql-f04203ab7e683bc3e961a40b002cf3c8d1d12100.tar.gz
postgresql-f04203ab7e683bc3e961a40b002cf3c8d1d12100.zip
Fix misleading error message about inconsistent moving-aggregate types.
We reported the wrong types when complaining that an aggregate's moving-aggregate implementation is inconsistent with its regular implementation. This was wrong since the feature was introduced, so back-patch to all supported branches. Jeff Janes Discussion: https://postgr.es/m/CAMkU=1x808LH=LPhZp9mNSP0Xd1xDqEd+XeGcvEe48dfE6xV=A@mail.gmail.com
-rw-r--r--src/backend/catalog/pg_aggregate.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/catalog/pg_aggregate.c b/src/backend/catalog/pg_aggregate.c
index 7d887ea24a2..6707fbcbf59 100644
--- a/src/backend/catalog/pg_aggregate.c
+++ b/src/backend/catalog/pg_aggregate.c
@@ -564,8 +564,8 @@ AggregateCreate(const char *aggName,
ereport(ERROR,
(errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
errmsg("moving-aggregate implementation returns type %s, but plain implementation returns type %s",
- format_type_be(aggmTransType),
- format_type_be(aggTransType))));
+ format_type_be(rettype),
+ format_type_be(finaltype))));
}
/* handle sortop, if supplied */