aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2020-09-06 12:55:13 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2020-09-06 12:55:37 -0400
commitf45dd3fed9cf7d336af08b53a1f73bf90c88fb1a (patch)
tree8ac7845d56bd5503585fa10b13e7f4188f55adba
parenta7bcf391f329561307a3d936443a715ad74a2e9d (diff)
downloadpostgresql-f45dd3fed9cf7d336af08b53a1f73bf90c88fb1a.tar.gz
postgresql-f45dd3fed9cf7d336af08b53a1f73bf90c88fb1a.zip
Fix misleading error message about inconsistent moving-aggregate types.
We reported the wrong types when complaining that an aggregate's moving-aggregate implementation is inconsistent with its regular implementation. This was wrong since the feature was introduced, so back-patch to all supported branches. Jeff Janes Discussion: https://postgr.es/m/CAMkU=1x808LH=LPhZp9mNSP0Xd1xDqEd+XeGcvEe48dfE6xV=A@mail.gmail.com
-rw-r--r--src/backend/catalog/pg_aggregate.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/catalog/pg_aggregate.c b/src/backend/catalog/pg_aggregate.c
index fd248a90ff4..3e724c786bd 100644
--- a/src/backend/catalog/pg_aggregate.c
+++ b/src/backend/catalog/pg_aggregate.c
@@ -563,8 +563,8 @@ AggregateCreate(const char *aggName,
ereport(ERROR,
(errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
errmsg("moving-aggregate implementation returns type %s, but plain implementation returns type %s",
- format_type_be(aggmTransType),
- format_type_be(aggTransType))));
+ format_type_be(rettype),
+ format_type_be(finaltype))));
}
/* handle sortop, if supplied */