diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2020-08-03 12:39:15 +1200 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2020-08-03 12:43:11 +1200 |
| commit | f5293fb09e7346bb663f2f5c63081e8aabe61a8e (patch) | |
| tree | b42c4faa9671ae6bac11fab2d19b93ca131bd7d4 | |
| parent | 719304a3043d9f60247df371f55236058a7f3caa (diff) | |
| download | postgresql-f5293fb09e7346bb663f2f5c63081e8aabe61a8e.tar.gz postgresql-f5293fb09e7346bb663f2f5c63081e8aabe61a8e.zip | |
Fix rare failure in LDAP tests.
Instead of writing a query to psql's stdin, use -c. This avoids a
failure where psql exits before we write, seen a few times on the build
farm. Thanks to Tom Lane for the suggestion.
Back-patch to 11, where the LDAP tests arrived.
Reviewed-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/CA%2BhUKGLFmW%2BHQYPeKiwSp5sdFFHtFViCpw4Mh6yAgEx74r5-Cw%40mail.gmail.com
| -rw-r--r-- | src/test/ldap/t/001_auth.pl | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/test/ldap/t/001_auth.pl b/src/test/ldap/t/001_auth.pl index f8941144f5e..3bc7672451e 100644 --- a/src/test/ldap/t/001_auth.pl +++ b/src/test/ldap/t/001_auth.pl @@ -165,7 +165,8 @@ sub test_access my ($node, $role, $expected_res, $test_name) = @_; my $res = - $node->psql('postgres', 'SELECT 1', extra_params => [ '-U', $role ]); + $node->psql('postgres', undef, + extra_params => [ '-U', $role, '-c', 'SELECT 1' ]); is($res, $expected_res, $test_name); return; } |