diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-10-16 13:56:58 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-10-16 13:56:58 -0400 |
| commit | f7a953c2d870185499faaabd06983526a83eb387 (patch) | |
| tree | 384c8fe68ada5cd8f597c46f1f7a4e90f413b8d5 | |
| parent | fd85e9f78d44f0f36776e644380ada077451c992 (diff) | |
| download | postgresql-f7a953c2d870185499faaabd06983526a83eb387.tar.gz postgresql-f7a953c2d870185499faaabd06983526a83eb387.zip | |
Avoid rare race condition in privileges.sql regression test.
We created a temp table, then switched to a new session, leaving
the old session to clean up its temp objects in background. If that
took long enough, the eventual attempt to drop the user that owns
the temp table could fail, as exhibited today by sidewinder.
Fix by dropping the temp table explicitly when we're done with it.
It's been like this for quite some time, so back-patch to all
supported branches.
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sidewinder&dt=2018-10-16%2014%3A45%3A00
| -rw-r--r-- | src/test/regress/expected/privileges.out | 1 | ||||
| -rw-r--r-- | src/test/regress/sql/privileges.sql | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/src/test/regress/expected/privileges.out b/src/test/regress/expected/privileges.out index aebc89c1b08..7d5d1f0bc1e 100644 --- a/src/test/regress/expected/privileges.out +++ b/src/test/regress/expected/privileges.out @@ -1189,6 +1189,7 @@ select has_column_privilege('mytable',2::int2,'select'); (1 row) +drop table mytable; -- Grant options SET SESSION AUTHORIZATION regress_priv_user1; CREATE TABLE atest4 (a int); diff --git a/src/test/regress/sql/privileges.sql b/src/test/regress/sql/privileges.sql index 0c0bba6cf7f..cf9fa9f7823 100644 --- a/src/test/regress/sql/privileges.sql +++ b/src/test/regress/sql/privileges.sql @@ -732,6 +732,7 @@ select has_column_privilege('mytable','........pg.dropped.2........','select'); select has_column_privilege('mytable',2::int2,'select'); revoke select on table mytable from regress_priv_user3; select has_column_privilege('mytable',2::int2,'select'); +drop table mytable; -- Grant options |