diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2024-09-13 16:16:47 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2024-09-13 16:17:04 -0400 |
| commit | fae55f0bb38504b3774fa50152d3c14d2f09aa15 (patch) | |
| tree | 3ae1790d280cc5fbfd4a16e63ebe07740820323d | |
| parent | 9a23967063b1b36c620a753f72c7cdb56dc0a4c4 (diff) | |
| download | postgresql-fae55f0bb38504b3774fa50152d3c14d2f09aa15.tar.gz postgresql-fae55f0bb38504b3774fa50152d3c14d2f09aa15.zip | |
Allow _h_indexbuild() to be interrupted.
When we are building a hash index that is large enough to need
pre-sorting (larger than either maintenance_work_mem or NBuffers),
the initial sorting phase is interruptible, but the insertion
phase wasn't. Add the missing CHECK_FOR_INTERRUPTS().
Per bug #18616 from Alexander Lakhin. Back-patch to all
supported branches.
Pavel Borisov
Discussion: https://postgr.es/m/18616-acbb9e5caf41e964@postgresql.org
| -rw-r--r-- | src/backend/access/hash/hashsort.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/access/hash/hashsort.c b/src/backend/access/hash/hashsort.c index 149cd9fc056..e608d533629 100644 --- a/src/backend/access/hash/hashsort.c +++ b/src/backend/access/hash/hashsort.c @@ -148,6 +148,9 @@ _h_indexbuild(HSpool *hspool, Relation heapRel) /* the tuples are sorted by hashkey, so pass 'sorted' as true */ _hash_doinsert(hspool->index, itup, heapRel, true); + /* allow insertion phase to be interrupted, and track progress */ + CHECK_FOR_INTERRUPTS(); + pgstat_progress_update_param(PROGRESS_CREATEIDX_TUPLES_DONE, ++tups_done); } |