diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2015-08-21 20:32:11 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2015-08-21 20:32:26 -0400 |
| commit | fe939d950e362094c14e97f4e91c063374588534 (patch) | |
| tree | 54d373582e7c3d38d668d49f594941af809dddf7 | |
| parent | 22b9ce79879bdf0aa8ff56ca4973f894ed69813c (diff) | |
| download | postgresql-fe939d950e362094c14e97f4e91c063374588534.tar.gz postgresql-fe939d950e362094c14e97f4e91c063374588534.zip | |
Avoid O(N^2) behavior when enlarging SPI tuple table in spi_printtup().
For no obvious reason, spi_printtup() was coded to enlarge the tuple
pointer table by just 256 slots at a time, rather than doubling the size at
each reallocation, as is our usual habit. For very large SPI results, this
makes for O(N^2) time spent in repalloc(), which of course soon comes to
dominate the runtime. Use the standard doubling approach instead.
This is a longstanding performance bug, so back-patch to all active
branches.
Neil Conway
| -rw-r--r-- | src/backend/executor/spi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c index cfa4a24686f..649040e8fd7 100644 --- a/src/backend/executor/spi.c +++ b/src/backend/executor/spi.c @@ -1769,7 +1769,8 @@ spi_printtup(TupleTableSlot *slot, DestReceiver *self) if (tuptable->free == 0) { - tuptable->free = 256; + /* Double the size of the pointer array */ + tuptable->free = tuptable->alloced; tuptable->alloced += tuptable->free; tuptable->vals = (HeapTuple *) repalloc(tuptable->vals, tuptable->alloced * sizeof(HeapTuple)); |