diff options
| author | Michael Paquier <michael@paquier.xyz> | 2021-08-19 10:42:44 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2021-08-19 10:42:44 +0900 |
| commit | 32cf7f7acce3891cbc3de53327704372bdd36d38 (patch) | |
| tree | 6bce685687873526523c6059fccc348cd4f53c30 /contrib/btree_gist/btree_utils_num.h | |
| parent | 2576dcfb76aa71e4222bac5a3a43f71875bfa9e8 (diff) | |
| download | postgresql-32cf7f7acce3891cbc3de53327704372bdd36d38.tar.gz postgresql-32cf7f7acce3891cbc3de53327704372bdd36d38.zip | |
Improve performance of float overflow checks in btree_gist
The current code could do unnecessary calls to isinf() (two for the
argument values all the time while one could be sufficient in some
cases). zero_is_valid was never used but the result value was still
checked on 0 in the first position of the check.
This is similar to 607f8ce. btree_gist has just copy-pasted the code
doing those checks from the backend float4/8 code, as of the macro
CHECKFLOATVAL(), to do the work.
Author: Haiying Tang
Discussion: https://postgr.es/m/OS0PR01MB611358E3A7BC3C2F874AC36BFBF39@OS0PR01MB6113.jpnprd01.prod.outlook.com
Diffstat (limited to 'contrib/btree_gist/btree_utils_num.h')
| -rw-r--r-- | contrib/btree_gist/btree_utils_num.h | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/contrib/btree_gist/btree_utils_num.h b/contrib/btree_gist/btree_utils_num.h index cec69861726..415a7a6459a 100644 --- a/contrib/btree_gist/btree_utils_num.h +++ b/contrib/btree_gist/btree_utils_num.h @@ -89,23 +89,6 @@ typedef struct #define GET_FLOAT_DISTANCE(t, arg1, arg2) Abs( ((float8) *((const t *) (arg1))) - ((float8) *((const t *) (arg2))) ) -/* - * check to see if a float4/8 val has underflowed or overflowed - * borrowed from src/backend/utils/adt/float.c - */ -#define CHECKFLOATVAL(val, inf_is_valid, zero_is_valid) \ -do { \ - if (isinf(val) && !(inf_is_valid)) \ - ereport(ERROR, \ - (errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE), \ - errmsg("value out of range: overflow"))); \ - \ - if ((val) == 0.0 && !(zero_is_valid)) \ - ereport(ERROR, \ - (errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE), \ - errmsg("value out of range: underflow"))); \ -} while(0) - extern Interval *abs_interval(Interval *a); |