diff options
| author | Andres Freund <andres@anarazel.de> | 2018-11-27 10:07:43 -0800 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2018-11-27 10:07:43 -0800 |
| commit | aee085bc018ffb961bf0a2c3ac72a45bb3aa33a9 (patch) | |
| tree | 9d509cb312c68e63a98997a0d27ce48bc017419b /contrib/postgres_fdw/connection.c | |
| parent | 5ef8f08b541da5df1ac00a3c880578a8e3bf447c (diff) | |
| download | postgresql-aee085bc018ffb961bf0a2c3ac72a45bb3aa33a9.tar.gz postgresql-aee085bc018ffb961bf0a2c3ac72a45bb3aa33a9.zip | |
Fix jit compilation bug on wide tables.
The function generated to perform JIT compiled tuple deforming failed
when HeapTupleHeader's t_hoff was bigger than a signed int8. I'd
failed to realize that LLVM's getelementptr would treat an int8 index
argument as signed, rather than unsigned. That means that a hoff
larger than 127 would result in a negative offset being applied. Fix
that by widening the index to 32bit.
Add a testcase with a wide table. Don't drop it, as it seems useful to
verify other tools deal properly with wide tables.
Thanks to Justin Pryzby for both reporting a bug and then reducing it
to a reproducible testcase!
Reported-By: Justin Pryzby
Author: Andres Freund
Discussion: https://postgr.es/m/20181115223959.GB10913@telsasoft.com
Backpatch: 11, just as jit compilation was
Diffstat (limited to 'contrib/postgres_fdw/connection.c')
0 files changed, 0 insertions, 0 deletions