diff options
| author | Peter Eisentraut <peter_e@gmx.net> | 2014-04-18 00:03:19 -0400 |
|---|---|---|
| committer | Peter Eisentraut <peter_e@gmx.net> | 2014-04-18 00:03:19 -0400 |
| commit | e7128e8dbb305059c30ec085461297e619bcbff4 (patch) | |
| tree | ed4bf968847b30a098d113bb787adc2b97c687e0 /contrib/postgres_fdw/option.c | |
| parent | 01563158235f5650743fd9b1dfa80c3d8faf89bb (diff) | |
| download | postgresql-e7128e8dbb305059c30ec085461297e619bcbff4.tar.gz postgresql-e7128e8dbb305059c30ec085461297e619bcbff4.zip | |
Create function prototype as part of PG_FUNCTION_INFO_V1 macro
Because of gcc -Wmissing-prototypes, all functions in dynamically
loadable modules must have a separate prototype declaration. This is
meant to detect global functions that are not declared in header files,
but in cases where the function is called via dfmgr, this is redundant.
Besides filling up space with boilerplate, this is a frequent source of
compiler warnings in extension modules.
We can fix that by creating the function prototype as part of the
PG_FUNCTION_INFO_V1 macro, which such modules have to use anyway. That
makes the code of modules cleaner, because there is one less place where
the entry points have to be listed, and creates an additional check that
functions have the right prototype.
Remove now redundant prototypes from contrib and other modules.
Diffstat (limited to 'contrib/postgres_fdw/option.c')
| -rw-r--r-- | contrib/postgres_fdw/option.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/contrib/postgres_fdw/option.c b/contrib/postgres_fdw/option.c index 8ba2be5ca63..6f98dfcb234 100644 --- a/contrib/postgres_fdw/option.c +++ b/contrib/postgres_fdw/option.c @@ -57,8 +57,6 @@ static bool is_libpq_option(const char *keyword); * * Raise an ERROR if the option or its value is considered invalid. */ -extern Datum postgres_fdw_validator(PG_FUNCTION_ARGS); - PG_FUNCTION_INFO_V1(postgres_fdw_validator); Datum |