diff options
| author | Andres Freund <andres@anarazel.de> | 2019-06-10 23:20:48 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2019-06-10 23:36:59 -0700 |
| commit | 483b2d7ae173e29515ec1473880fd173208144b0 (patch) | |
| tree | b168d51a1b7f103ef7139939ffa56e2575e9d907 /contrib/postgres_fdw/postgres_fdw.c | |
| parent | 99b5ff2eaf4c64c6ac8204f622075d7f01ff4cc2 (diff) | |
| download | postgresql-483b2d7ae173e29515ec1473880fd173208144b0.tar.gz postgresql-483b2d7ae173e29515ec1473880fd173208144b0.zip | |
Don't access catalogs to validate GUCs when not connected to a DB.
Vignesh found this bug in the check function for
default_table_access_method's check hook, but that was just copied
from older GUCs. Investigation by Michael and me then found the bug in
further places.
When not connected to a database (e.g. in a walsender connection), we
cannot perform (most) GUC checks that need database access. Even when
only shared tables are needed, unless they're
nailed (c.f. RelationCacheInitializePhase2()), they cannot be accessed
without pg_class etc. being present.
Fix by extending the existing IsTransactionState() checks to also
check for MyDatabaseOid.
Reported-By: Vignesh C, Michael Paquier, Andres Freund
Author: Vignesh C, Andres Freund
Discussion: https://postgr.es/m/CALDaNm1KXK9gbZfY-p_peRFm_XrBh1OwQO1Kk6Gig0c0fVZ2uw%40mail.gmail.com
Backpatch: 9.4-
Diffstat (limited to 'contrib/postgres_fdw/postgres_fdw.c')
0 files changed, 0 insertions, 0 deletions