diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2013-03-22 17:22:31 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2013-03-22 17:22:31 -0400 |
commit | 5b86fedfb57ea943f883a13c6d50c5a9e2a1cc57 (patch) | |
tree | 36bfff9b4b7794abb5f04fc9e91afc36ba23f9b2 /contrib/postgres_fdw/postgres_fdw.c | |
parent | 8a3b6772aedbd95557ab1fc489ddf007ac9d405d (diff) | |
download | postgresql-5b86fedfb57ea943f883a13c6d50c5a9e2a1cc57.tar.gz postgresql-5b86fedfb57ea943f883a13c6d50c5a9e2a1cc57.zip |
Document cross-version compatibility issues for contrib/postgres_fdw.
One of the use-cases for postgres_fdw is extracting data from older PG
servers, so cross-version compatibility is important. Document what we
can do here, and further annotate some of the coding choices that create
compatibility constraints. In passing, remove one unnecessary
incompatibility with old servers, namely assuming that we didn't need to
quote the timezone name 'UTC'.
Diffstat (limited to 'contrib/postgres_fdw/postgres_fdw.c')
-rw-r--r-- | contrib/postgres_fdw/postgres_fdw.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index 687b87b8604..49dfe2c5edb 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -801,6 +801,9 @@ postgresGetForeignPlan(PlannerInfo *root, * The extra roundtrips involved in trying to duplicate the local * semantics exactly don't seem worthwhile (see also comments for * RowMarkType). + * + * Note: because we actually run the query as a cursor, this assumes that + * DECLARE CURSOR ... FOR UPDATE is supported, which it isn't before 8.3. */ if (baserel->relid == root->parse->resultRelation && (root->parse->commandType == CMD_UPDATE || |