diff options
| author | Fujii Masao <fujii@postgresql.org> | 2022-07-21 22:52:50 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2022-07-22 12:01:31 +0900 |
| commit | 63a8c689b0d49b8f426c5075d37dd67a63e06f82 (patch) | |
| tree | 6853dd5793d87c6d9b21ef470dc95762e7a0a775 /contrib/postgres_fdw/postgres_fdw.c | |
| parent | d5623c447c743cce3913559a353451711b6fa2f4 (diff) | |
| download | postgresql-63a8c689b0d49b8f426c5075d37dd67a63e06f82.tar.gz postgresql-63a8c689b0d49b8f426c5075d37dd67a63e06f82.zip | |
postgres_fdw: Fix bug in checking of return value of PQsendQuery().
When postgres_fdw begins an asynchronous data fetch, it submits FETCH query
by using PQsendQuery(). If PQsendQuery() fails and returns 0, postgres_fdw
should report an error. But, previously, postgres_fdw reported an error
only when the return value is less than 0, though PQsendQuery() never return
the values other than 0 and 1. Therefore postgres_fdw could not handle
the failure to send FETCH query in an asynchronous data fetch.
This commit fixes postgres_fdw so that it reports an error
when PQsendQuery() returns 0.
Back-patch to v14 where asynchronous execution was supported in postgres_fdw.
Author: Fujii Masao
Reviewed-by: Japin Li, Tom Lane
Discussion: https://postgr.es/m/b187a7cf-d4e3-5a32-4d01-8383677797f3@oss.nttdata.com
Diffstat (limited to 'contrib/postgres_fdw/postgres_fdw.c')
| -rw-r--r-- | contrib/postgres_fdw/postgres_fdw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index 2ff6debebfb..9b340453b63 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -7078,7 +7078,7 @@ fetch_more_data_begin(AsyncRequest *areq) snprintf(sql, sizeof(sql), "FETCH %d FROM c%u", fsstate->fetch_size, fsstate->cursor_number); - if (PQsendQuery(fsstate->conn, sql) < 0) + if (!PQsendQuery(fsstate->conn, sql)) pgfdw_report_error(ERROR, NULL, fsstate->conn, false, fsstate->query); /* Remember that the request is in process */ |