diff options
| author | Noah Misch <noah@leadboat.com> | 2014-03-23 02:16:34 -0400 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2014-03-23 02:16:34 -0400 |
| commit | 7cbe57c34dec4860243e6d0f81738cfbb6e5d069 (patch) | |
| tree | 1b2e725b85caef56f986db8ae7c43732819c1f5c /contrib/postgres_fdw/postgres_fdw.c | |
| parent | 6115480c543c0141011a99db78987ad13540be59 (diff) | |
| download | postgresql-7cbe57c34dec4860243e6d0f81738cfbb6e5d069.tar.gz postgresql-7cbe57c34dec4860243e6d0f81738cfbb6e5d069.zip | |
Offer triggers on foreign tables.
This covers all the SQL-standard trigger types supported for regular
tables; it does not cover constraint triggers. The approach for
acquiring the old row mirrors that for view INSTEAD OF triggers. For
AFTER ROW triggers, we spool the foreign tuples to a tuplestore.
This changes the FDW API contract; when deciding which columns to
populate in the slot returned from data modification callbacks, writable
FDWs will need to check for AFTER ROW triggers in addition to checking
for a RETURNING clause.
In support of the feature addition, refactor the TriggerFlags bits and
the assembly of old tuples in ModifyTable.
Ronan Dunklau, reviewed by KaiGai Kohei; some additional hacking by me.
Diffstat (limited to 'contrib/postgres_fdw/postgres_fdw.c')
| -rw-r--r-- | contrib/postgres_fdw/postgres_fdw.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index 1ae1c184372..d7c5fa21195 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -108,7 +108,7 @@ enum FdwScanPrivateIndex * 1) INSERT/UPDATE/DELETE statement text to be sent to the remote server * 2) Integer list of target attribute numbers for INSERT/UPDATE * (NIL for a DELETE) - * 3) Boolean flag showing if there's a RETURNING clause + * 3) Boolean flag showing if the remote query has a RETURNING clause * 4) Integer list of attribute numbers retrieved by RETURNING, if any */ enum FdwModifyPrivateIndex @@ -1246,7 +1246,7 @@ postgresPlanForeignModify(PlannerInfo *root, */ return list_make4(makeString(sql.data), targetAttrs, - makeInteger((returningList != NIL)), + makeInteger((retrieved_attrs != NIL)), retrieved_attrs); } |