diff options
| author | Tomas Vondra <tomas.vondra@postgresql.org> | 2022-02-12 23:50:42 +0100 |
|---|---|---|
| committer | Tomas Vondra <tomas.vondra@postgresql.org> | 2022-02-12 23:50:42 +0100 |
| commit | b779d7d8fdae088d70da5ed9fcd8205035676df3 (patch) | |
| tree | dc6733e833b2423d43ebb8e2385774cb9b9a3778 /contrib/test_decoding/sql | |
| parent | faa189c932d51945b2285e277128b0f26b96afdd (diff) | |
| download | postgresql-b779d7d8fdae088d70da5ed9fcd8205035676df3.tar.gz postgresql-b779d7d8fdae088d70da5ed9fcd8205035676df3.zip | |
Fix skip-empty-xacts with sequences in test_decoding
Regression tests need to use skip-empty-xacts = false, because there
might be accidental concurrent activity (like autovacuum), particularly
on slow machines. The tests added by 80901b3291 failed to do that in a
couple places, triggering occasional failures on buildfarm.
Fixing the tests however uncovered a bug in the code, because sequence
callbacks did not handle skip-empty-xacts properly. For trasactional
increments we need to check/update the xact_wrote_changes flag, and emit
the BEGIN if it's the first change in the transaction.
Reported-by: Andres Freund
Discussion: https://postgr.es/m/20220212220413.b25amklo7t4xb7ni%40alap3.anarazel.de
Diffstat (limited to 'contrib/test_decoding/sql')
| -rw-r--r-- | contrib/test_decoding/sql/sequence.sql | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/contrib/test_decoding/sql/sequence.sql b/contrib/test_decoding/sql/sequence.sql index 42ad9113bf4..978ee8088e1 100644 --- a/contrib/test_decoding/sql/sequence.sql +++ b/contrib/test_decoding/sql/sequence.sql @@ -28,7 +28,7 @@ SELECT setval('test_sequence', 3500, false); SELECT nextval('test_sequence'); -- show results and drop sequence -SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '0'); +SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1'); DROP SEQUENCE test_sequence; -- rollback on sequence creation and update @@ -87,7 +87,7 @@ SELECT * from test_table_a_seq; SELECT nextval('test_table_a_seq'); DROP TABLE test_table; -SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '0'); +SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1'); -- savepoint test on table with serial column BEGIN; @@ -99,7 +99,7 @@ INSERT INTO test_table (b) VALUES (300); ROLLBACK TO SAVEPOINT a; DROP TABLE test_table; COMMIT; -SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '0'); +SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1'); -- savepoint test on table with serial column BEGIN; @@ -114,6 +114,6 @@ ROLLBACK TO SAVEPOINT a; SELECT * FROM test_sequence; DROP SEQUENCE test_sequence; COMMIT; -SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '0'); +SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1'); SELECT pg_drop_replication_slot('regression_slot'); |