diff options
| author | Peter Eisentraut <peter_e@gmx.net> | 2014-04-18 00:03:19 -0400 |
|---|---|---|
| committer | Peter Eisentraut <peter_e@gmx.net> | 2014-04-18 00:03:19 -0400 |
| commit | e7128e8dbb305059c30ec085461297e619bcbff4 (patch) | |
| tree | ed4bf968847b30a098d113bb787adc2b97c687e0 /contrib/test_parser/test_parser.c | |
| parent | 01563158235f5650743fd9b1dfa80c3d8faf89bb (diff) | |
| download | postgresql-e7128e8dbb305059c30ec085461297e619bcbff4.tar.gz postgresql-e7128e8dbb305059c30ec085461297e619bcbff4.zip | |
Create function prototype as part of PG_FUNCTION_INFO_V1 macro
Because of gcc -Wmissing-prototypes, all functions in dynamically
loadable modules must have a separate prototype declaration. This is
meant to detect global functions that are not declared in header files,
but in cases where the function is called via dfmgr, this is redundant.
Besides filling up space with boilerplate, this is a frequent source of
compiler warnings in extension modules.
We can fix that by creating the function prototype as part of the
PG_FUNCTION_INFO_V1 macro, which such modules have to use anyway. That
makes the code of modules cleaner, because there is one less place where
the entry points have to be listed, and creates an additional check that
functions have the right prototype.
Remove now redundant prototypes from contrib and other modules.
Diffstat (limited to 'contrib/test_parser/test_parser.c')
| -rw-r--r-- | contrib/test_parser/test_parser.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/contrib/test_parser/test_parser.c b/contrib/test_parser/test_parser.c index 932d9248a38..c41d1eb201c 100644 --- a/contrib/test_parser/test_parser.c +++ b/contrib/test_parser/test_parser.c @@ -38,23 +38,13 @@ typedef struct } LexDescr; /* - * prototypes + * functions */ PG_FUNCTION_INFO_V1(testprs_start); -Datum testprs_start(PG_FUNCTION_ARGS); - PG_FUNCTION_INFO_V1(testprs_getlexeme); -Datum testprs_getlexeme(PG_FUNCTION_ARGS); - PG_FUNCTION_INFO_V1(testprs_end); -Datum testprs_end(PG_FUNCTION_ARGS); - PG_FUNCTION_INFO_V1(testprs_lextype); -Datum testprs_lextype(PG_FUNCTION_ARGS); -/* - * functions - */ Datum testprs_start(PG_FUNCTION_ARGS) { |