diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2008-03-26 01:19:17 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2008-03-26 01:19:17 +0000 |
| commit | 270b3adb16bf60b54202cc1c31a90abf8c8eed20 (patch) | |
| tree | d33adf8aeca50c31f569e826f894092f03425e4a /contrib/xml2/xpath.c | |
| parent | 0a11e1063d5773eecce7f598f153b235ad8c02c8 (diff) | |
| download | postgresql-270b3adb16bf60b54202cc1c31a90abf8c8eed20.tar.gz postgresql-270b3adb16bf60b54202cc1c31a90abf8c8eed20.zip | |
Fix core dump in contrib/xml2's xpath_table() when the input query returns
a NULL value. Per bug #4058.
Diffstat (limited to 'contrib/xml2/xpath.c')
| -rw-r--r-- | contrib/xml2/xpath.c | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/contrib/xml2/xpath.c b/contrib/xml2/xpath.c index 11349eff0b0..e0b3f4155bc 100644 --- a/contrib/xml2/xpath.c +++ b/contrib/xml2/xpath.c @@ -808,12 +808,10 @@ xpath_table(PG_FUNCTION_ARGS) xmlXPathCompExprPtr comppath; /* Extract the row data as C Strings */ - spi_tuple = tuptable->vals[i]; pkey = SPI_getvalue(spi_tuple, spi_tupdesc, 1); xmldoc = SPI_getvalue(spi_tuple, spi_tupdesc, 2); - /* * Clear the values array, so that not-well-formed documents return * NULL in all columns. @@ -827,11 +825,14 @@ xpath_table(PG_FUNCTION_ARGS) values[0] = pkey; /* Parse the document */ - doctree = xmlParseMemory(xmldoc, strlen(xmldoc)); + if (xmldoc) + doctree = xmlParseMemory(xmldoc, strlen(xmldoc)); + else /* treat NULL as not well-formed */ + doctree = NULL; if (doctree == NULL) - { /* not well-formed, so output all-NULL tuple */ - + { + /* not well-formed, so output all-NULL tuple */ ret_tuple = BuildTupleFromCStrings(attinmeta, values); oldcontext = MemoryContextSwitchTo(per_query_ctx); tuplestore_puttuple(tupstore, ret_tuple); @@ -923,8 +924,10 @@ xpath_table(PG_FUNCTION_ARGS) xmlFreeDoc(doctree); - pfree(pkey); - pfree(xmldoc); + if (pkey) + pfree(pkey); + if (xmldoc) + pfree(xmldoc); } xmlCleanupParser(); |