diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-09-17 12:52:18 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-09-17 12:52:18 -0400 |
| commit | 99175141c9254318e5894ac30b9fdb622612acda (patch) | |
| tree | 2afcbc8352aca1296a371c41cc7d3a2a2ccecb3a /doc/src | |
| parent | b7f2dd959a5082540adbeee1dea0c0b1c154374f (diff) | |
| download | postgresql-99175141c9254318e5894ac30b9fdb622612acda.tar.gz postgresql-99175141c9254318e5894ac30b9fdb622612acda.zip | |
Improve common/logging.c's support for multiple verbosity levels.
Instead of hard-wiring specific verbosity levels into the option
processing of client applications, invent pg_logging_increase_verbosity()
and encourage clients to implement --verbose by calling that. Then,
the common convention that more -v's gets you more verbosity just works.
In particular, this allows resurrection of the debug-grade messages that
have long existed in pg_dump and its siblings. They were unreachable
before this commit due to lack of a way to select PG_LOG_DEBUG logging
level. (It appears that they may have been unreachable for some time
before common/logging.c was introduced, too, so I'm not specifically
blaming cc8d41511 for the oversight. One reason for thinking that is
that it's now apparent that _allocAH()'s message needs a null-pointer
guard. Testing might have failed to reveal that before 96bf88d52.)
Discussion: https://postgr.es/m/1173106.1600116625@sss.pgh.pa.us
Diffstat (limited to 'doc/src')
| -rw-r--r-- | doc/src/sgml/ref/pg_dump.sgml | 2 | ||||
| -rw-r--r-- | doc/src/sgml/ref/pg_dumpall.sgml | 4 | ||||
| -rw-r--r-- | doc/src/sgml/ref/pg_restore.sgml | 7 |
3 files changed, 11 insertions, 2 deletions
diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml index 0b2e2de87b6..0ec99165c5c 100644 --- a/doc/src/sgml/ref/pg_dump.sgml +++ b/doc/src/sgml/ref/pg_dump.sgml @@ -594,6 +594,8 @@ PostgreSQL documentation <application>pg_dump</application> to output detailed object comments and start/stop times to the dump file, and progress messages to standard error. + Repeating the option causes additional debug-level messages + to appear on standard error. </para> </listitem> </varlistentry> diff --git a/doc/src/sgml/ref/pg_dumpall.sgml b/doc/src/sgml/ref/pg_dumpall.sgml index 43abc530a0f..5b514e4567b 100644 --- a/doc/src/sgml/ref/pg_dumpall.sgml +++ b/doc/src/sgml/ref/pg_dumpall.sgml @@ -202,7 +202,9 @@ PostgreSQL documentation Specifies verbose mode. This will cause <application>pg_dumpall</application> to output start/stop times to the dump file, and progress messages to standard error. - It will also enable verbose output in <application>pg_dump</application>. + Repeating the option causes additional debug-level messages + to appear on standard error. + The option is also passed down to <application>pg_dump</application>. </para> </listitem> </varlistentry> diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml index 27eab2f02a5..e0d9d2ad64f 100644 --- a/doc/src/sgml/ref/pg_restore.sgml +++ b/doc/src/sgml/ref/pg_restore.sgml @@ -483,7 +483,12 @@ PostgreSQL documentation <term><option>--verbose</option></term> <listitem> <para> - Specifies verbose mode. + Specifies verbose mode. This will cause + <application>pg_restore</application> to output detailed object + comments and start/stop times to the output file, and progress + messages to standard error. + Repeating the option causes additional debug-level messages + to appear on standard error. </para> </listitem> </varlistentry> |