diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2024-09-11 15:15:49 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2024-09-11 15:21:36 +0200 |
| commit | 8b5c6a54c4396bb9daeb9ec5d9cbb0d3deedcbe3 (patch) | |
| tree | 437b1aaa5d0ee2b9c7a5aae05657a0acfcbaa0cb /src/backend/access/gin | |
| parent | 842265631dfd9e5583d934e2ae328b09bc4b2f8b (diff) | |
| download | postgresql-8b5c6a54c4396bb9daeb9ec5d9cbb0d3deedcbe3.tar.gz postgresql-8b5c6a54c4396bb9daeb9ec5d9cbb0d3deedcbe3.zip | |
Replace gratuitous memmove() with memcpy()
The index access methods all had similar code that copied the
passed-in scan keys to local storage. They all used memmove() for
that, which is not wrong, but it seems confusing not to use memcpy()
when that would work. Presumably, this was all once copied from
ancient code and never adjusted.
Discussion: https://www.postgresql.org/message-id/flat/f8c739d9-f48d-4187-b214-df3391ba41ab@eisentraut.org
Diffstat (limited to 'src/backend/access/gin')
| -rw-r--r-- | src/backend/access/gin/ginscan.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/backend/access/gin/ginscan.c b/src/backend/access/gin/ginscan.c index af24d38544e..f2fd62afbbf 100644 --- a/src/backend/access/gin/ginscan.c +++ b/src/backend/access/gin/ginscan.c @@ -447,10 +447,7 @@ ginrescan(IndexScanDesc scan, ScanKey scankey, int nscankeys, ginFreeScanKeys(so); if (scankey && scan->numberOfKeys > 0) - { - memmove(scan->keyData, scankey, - scan->numberOfKeys * sizeof(ScanKeyData)); - } + memcpy(scan->keyData, scankey, scan->numberOfKeys * sizeof(ScanKeyData)); } |