diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-05-26 19:25:19 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-05-26 19:25:19 -0400 |
commit | 3987e9e62046bd800d8d08566ed49fee1ae6cb86 (patch) | |
tree | 19734041040d9f718b48d60499b0e5a4b0732aa8 /src/backend/access/gist/gist.c | |
parent | 44404f394517f89a0bebb1aaace6e64ad79d2817 (diff) | |
download | postgresql-3987e9e62046bd800d8d08566ed49fee1ae6cb86.tar.gz postgresql-3987e9e62046bd800d8d08566ed49fee1ae6cb86.zip |
Make decompilation of optimized CASE constructs more robust.
We had some hacks in ruleutils.c to cope with various odd transformations
that the optimizer could do on a CASE foo WHEN "CaseTestExpr = RHS" clause.
However, the fundamental impossibility of covering all cases was exposed
by Heikki, who pointed out that the "=" operator could get replaced by an
inlined SQL function, which could contain nearly anything at all. So give
up on the hacks and just print the expression as-is if we fail to recognize
it as "CaseTestExpr = RHS". (We must cover that case so that decompiled
rules print correctly; but we are not under any obligation to make EXPLAIN
output be 100% valid SQL in all cases, and already could not do so in some
other cases.) This approach requires that we have some printable
representation of the CaseTestExpr node type; I used "CASE_TEST_EXPR".
Back-patch to all supported branches, since the problem case fails in all.
Diffstat (limited to 'src/backend/access/gist/gist.c')
0 files changed, 0 insertions, 0 deletions