aboutsummaryrefslogtreecommitdiff
path: root/src/backend/access/gist/gistbuild.c
diff options
context:
space:
mode:
authorJeff Davis <jdavis@postgresql.org>2025-03-08 11:25:36 -0800
committerJeff Davis <jdavis@postgresql.org>2025-03-08 11:25:36 -0800
commit1852aea3f526b124b95585f7b1f655f3af04afd5 (patch)
tree95a98196996524a7b6f740dae6bb04adefda4070 /src/backend/access/gist/gistbuild.c
parent7fb880102138e45f58bf626cb2a4599bade8b172 (diff)
downloadpostgresql-1852aea3f526b124b95585f7b1f655f3af04afd5.tar.gz
postgresql-1852aea3f526b124b95585f7b1f655f3af04afd5.zip
Don't convert to and from floats in pg_dump.
Commit 8f427187db improved performance by remembering relation stats as native types rather than issuing a new query for each relation. Using native types is fine for integers like relpages; but reltuples is floating point. The commit controllled for that complexity by using setlocale(LC_NUMERIC, "C"). After that, Alexander Lakhin found a problem in pg_strtof(), fixed in 00d61a08c5. While we aren't aware of any more problems with that approach, it seems wise to just use a string the whole way for floating point values, as Corey's original patch did, and get rid of the setlocale(). Integers are still converted to native types to avoid wasting memory. Co-authored-by: Corey Huinker <corey.huinker@gmail.com> Discussion: https://postgr.es/m/3049348.1740855411@sss.pgh.pa.us Discussion: https://postgr.es/m/560cca3781740bd69881bb07e26eb8f65b09792c.camel%40j-davis.com
Diffstat (limited to 'src/backend/access/gist/gistbuild.c')
0 files changed, 0 insertions, 0 deletions