diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2015-08-06 22:14:07 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2015-08-06 22:14:28 -0400 |
| commit | de0227d8aef18c1013b26ab193e48a5122435154 (patch) | |
| tree | ce12b505feeaa3eff8dfadf55b6d7492bd7cf87b /src/backend/access/gist/gistbuildbuffers.c | |
| parent | e663f7561683c8ba7663a8c2115e5a00f84f17c2 (diff) | |
| download | postgresql-de0227d8aef18c1013b26ab193e48a5122435154.tar.gz postgresql-de0227d8aef18c1013b26ab193e48a5122435154.zip | |
Fix old oversight in join removal logic.
Commit 9e7e29c75ad441450f9b8287bd51c13521641e3b introduced an Assert that
join removal didn't reduce the eval_at set of any PlaceHolderVar to empty.
At first glance it looks like join_is_removable ensures that's true --- but
actually, the loop in join_is_removable skips PlaceHolderVars that are not
referenced above the join due to be removed. So, if we don't want any
empty eval_at sets, the right thing to do is to delete any now-unreferenced
PlaceHolderVars from the data structure entirely.
Per fuzz testing by Andreas Seltenreich. Back-patch to 9.3 where the
aforesaid Assert was added.
Diffstat (limited to 'src/backend/access/gist/gistbuildbuffers.c')
0 files changed, 0 insertions, 0 deletions