diff options
author | Andrew Gierth <rhodiumtoad@postgresql.org> | 2019-10-03 10:54:52 +0100 |
---|---|---|
committer | Andrew Gierth <rhodiumtoad@postgresql.org> | 2019-10-03 11:12:39 +0100 |
commit | 0b11dc01922b0f6376a27f84a34a52451e8f476c (patch) | |
tree | 55b27e068c9cff4f1c3cb996d574c20004ff946c /src/backend/access/gist/gistget.c | |
parent | 2a724cdbff0bef4b962255c1e322b4deb74c309e (diff) | |
download | postgresql-0b11dc01922b0f6376a27f84a34a52451e8f476c.tar.gz postgresql-0b11dc01922b0f6376a27f84a34a52451e8f476c.zip |
Selectively include window frames in expression walks/mutates.
query_tree_walker and query_tree_mutator were skipping the
windowClause of the query, without regard for the fact that the
startOffset and endOffset in a WindowClause node are expression trees
that need to be processed. This was an oversight in commit ec4be2ee6
from 2010 which added the expression fields; the main symptom is that
function parameters in window frame clauses don't work in inlined
functions.
Fix (as conservatively as possible since this needs to not break
existing out-of-tree callers) and add tests.
Backpatch all the way, since this has been broken since 9.0.
Per report from Alastair McKinley; fix by me with kibitzing and review
from Tom Lane.
Discussion: https://postgr.es/m/DB6PR0202MB2904E7FDDA9D81504D1E8C68E3800@DB6PR0202MB2904.eurprd02.prod.outlook.com
Diffstat (limited to 'src/backend/access/gist/gistget.c')
0 files changed, 0 insertions, 0 deletions