diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-08-27 14:16:30 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-08-27 14:16:30 -0400 |
commit | c68561cbea123dbd0bfdaaab7fbcb1dac7053326 (patch) | |
tree | 0add69bc807eb781dcf25eb8fddba00cd0df0dae /src/backend/access/gist/gistproc.c | |
parent | 30c62561a82c2b3b07cf6e58b42245e1ccc35b33 (diff) | |
download | postgresql-c68561cbea123dbd0bfdaaab7fbcb1dac7053326.tar.gz postgresql-c68561cbea123dbd0bfdaaab7fbcb1dac7053326.zip |
Ensure we discard unread/unsent data when abandoning a connection attempt.
There are assorted situations wherein PQconnectPoll() will abandon a
connection attempt and try again with different parameters (eg, SSL versus
not SSL). However, the code forgot to discard any pending data in libpq's
I/O buffers when doing this. In at least one case (server returns E
message during SSL negotiation), there is unread input data which bollixes
the next connection attempt. I have not checked to see whether this is
possible in the other cases where we close the socket and retry, but it
seems like a matter of good defensive programming to add explicit
buffer-flushing code to all of them.
This is one of several issues exposed by Daniel Farina's report of
misbehavior after a server-side fork failure.
This has been wrong since forever, so back-patch to all supported branches.
Diffstat (limited to 'src/backend/access/gist/gistproc.c')
0 files changed, 0 insertions, 0 deletions