diff options
| author | Peter Eisentraut <peter_e@gmx.net> | 2009-11-03 08:59:16 +0000 |
|---|---|---|
| committer | Peter Eisentraut <peter_e@gmx.net> | 2009-11-03 08:59:16 +0000 |
| commit | 59052a5122dbc56e5dfd615bb199a07ffb7bb03e (patch) | |
| tree | e2ff052b6f76e14db20fcd32ac8a0ae751669225 /src/backend/access/gist/gistutil.c | |
| parent | 01adc8afd55f3ae831e32b6ce19f7c61f4baac28 (diff) | |
| download | postgresql-59052a5122dbc56e5dfd615bb199a07ffb7bb03e.tar.gz postgresql-59052a5122dbc56e5dfd615bb199a07ffb7bb03e.zip | |
Fix obscure segfault condition in PL/Python
In PLy_output(), when the elog() call in the TRY branch throws an exception
(this can happen when a statement timeout kicks in, for example), the
PyErr_SetString() call in the CATCH branch can cause a segfault, because the
Py_XDECREF(so) call before it releases memory that is still used by the sv
variable that PyErr_SetString() uses as argument, because sv points into
memory owned by so.
Backpatched back to 8.0, where this code was introduced.
I also threw in a couple of volatile declarations for variables that are used
before and after the TRY. I don't think they caused the crash that I
observed, but they could become issues.
Diffstat (limited to 'src/backend/access/gist/gistutil.c')
0 files changed, 0 insertions, 0 deletions