diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-09-01 17:38:54 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-09-01 17:38:54 -0400 |
| commit | 01edb5c7fc3bcf6aea15f2b3be36189b52ad9d1a (patch) | |
| tree | ecdc6beba03ff3b1e032bdbcf16c63eff081c544 /src/backend/access/gist/gistxlog.c | |
| parent | f2fe1cbef11c5fc962e338c8523667314faa6d89 (diff) | |
| download | postgresql-01edb5c7fc3bcf6aea15f2b3be36189b52ad9d1a.tar.gz postgresql-01edb5c7fc3bcf6aea15f2b3be36189b52ad9d1a.zip | |
Improve division of labor between execParallel.c and nodeGather[Merge].c.
Move the responsibility for creating/destroying TupleQueueReaders into
execParallel.c, to avoid duplicative coding in nodeGather.c and
nodeGatherMerge.c. Also, instead of having DestroyTupleQueueReader do
shm_mq_detach, do it in the caller (which is now only ExecParallelFinish).
This means execParallel.c does both the attaching and detaching of the
tuple-queue-reader shm_mqs, which seems less weird than the previous
arrangement.
These changes also eliminate a vestigial memory leak (of the pei->tqueue
array). It's now demonstrable that rescans of Gather or GatherMerge don't
leak memory.
Discussion: https://postgr.es/m/8670.1504192177@sss.pgh.pa.us
Diffstat (limited to 'src/backend/access/gist/gistxlog.c')
0 files changed, 0 insertions, 0 deletions