diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2015-08-13 13:25:01 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2015-08-13 13:25:01 -0400 |
commit | 3bfd40180859e252090f072805ec24b16c360f2f (patch) | |
tree | 34efa6d7bc8de68da9cc1da66d490ed4e1e42c62 /src/backend/access/gist/gistxlog.c | |
parent | 83fd92290a4144db0963614e21c60a74d49abeb9 (diff) | |
download | postgresql-3bfd40180859e252090f072805ec24b16c360f2f.tar.gz postgresql-3bfd40180859e252090f072805ec24b16c360f2f.zip |
Improve regression test case to avoid depending on system catalog stats.
In commit 95f4e59c32866716 I added a regression test case that examined
the plan of a query on system catalogs. That isn't a terribly great idea
because the catalogs tend to change from version to version, or even
within a version if someone makes an unrelated regression-test change that
populates the catalogs a bit differently. Usually I try to make planner
test cases rely on test tables that have not changed since Berkeley days,
but I got sloppy in this case because the submitted crasher example queried
the catalogs and I didn't spend enough time on rewriting it. But it was a
problem waiting to happen, as I was rudely reminded when I tried to port
that patch into Salesforce's Postgres variant :-(. So spend a little more
effort and rewrite the query to not use any system catalogs. I verified
that this version still provokes the Assert if 95f4e59c32866716's code fix
is reverted.
I also removed the EXPLAIN output from the test, as it turns out that the
assertion occurs while considering a plan that isn't the one ultimately
selected anyway; so there's no value in risking any cross-platform
variation in that printout.
Back-patch to 9.2, like the previous patch.
Diffstat (limited to 'src/backend/access/gist/gistxlog.c')
0 files changed, 0 insertions, 0 deletions