diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2015-08-06 22:14:07 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2015-08-06 22:14:07 -0400 |
| commit | 8c7bb02409548a88fa02d6f8771e2a6ca27007d3 (patch) | |
| tree | 37035ed3da2977ad520e7659c8c0972363466f39 /src/backend/access/gist | |
| parent | d31e79415bc0cbae8b20192ab8a979c9ebbe5dac (diff) | |
| download | postgresql-8c7bb02409548a88fa02d6f8771e2a6ca27007d3.tar.gz postgresql-8c7bb02409548a88fa02d6f8771e2a6ca27007d3.zip | |
Fix old oversight in join removal logic.
Commit 9e7e29c75ad441450f9b8287bd51c13521641e3b introduced an Assert that
join removal didn't reduce the eval_at set of any PlaceHolderVar to empty.
At first glance it looks like join_is_removable ensures that's true --- but
actually, the loop in join_is_removable skips PlaceHolderVars that are not
referenced above the join due to be removed. So, if we don't want any
empty eval_at sets, the right thing to do is to delete any now-unreferenced
PlaceHolderVars from the data structure entirely.
Per fuzz testing by Andreas Seltenreich. Back-patch to 9.3 where the
aforesaid Assert was added.
Diffstat (limited to 'src/backend/access/gist')
0 files changed, 0 insertions, 0 deletions