diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2007-11-30 21:22:54 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2007-11-30 21:22:54 +0000 |
| commit | 895a94de6dffa71741586a2228275f66db03f8ca (patch) | |
| tree | 55ec3c2629305d83b35f98956c3c3bee449d86bb /src/backend/access/heap/heapam.c | |
| parent | f0f18c7087e04a60e2612151401b07df87e51d96 (diff) | |
| download | postgresql-895a94de6dffa71741586a2228275f66db03f8ca.tar.gz postgresql-895a94de6dffa71741586a2228275f66db03f8ca.zip | |
Avoid incrementing the CommandCounter when CommandCounterIncrement is called
but no database changes have been made since the last CommandCounterIncrement.
This should result in a significant improvement in the number of "commands"
that can typically be performed within a transaction before hitting the 2^32
CommandId size limit. In particular this buys back (and more) the possible
adverse consequences of my previous patch to fix plan caching behavior.
The implementation requires tracking whether the current CommandCounter
value has been "used" to mark any tuples. CommandCounter values stored into
snapshots are presumed not to be used for this purpose. This requires some
small executor changes, since the executor used to conflate the curcid of
the snapshot it was using with the command ID to mark output tuples with.
Separating these concepts allows some small simplifications in executor APIs.
Something for the TODO list: look into having CommandCounterIncrement not do
AcceptInvalidationMessages. It seems fairly bogus to be doing it there,
but exactly where to do it instead isn't clear, and I'm disinclined to mess
with asynchronous behavior during late beta.
Diffstat (limited to 'src/backend/access/heap/heapam.c')
| -rw-r--r-- | src/backend/access/heap/heapam.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index 20027592b50..1a4fc92f1c2 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.245 2007/11/15 21:14:32 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.246 2007/11/30 21:22:53 tgl Exp $ * * * INTERFACE ROUTINES @@ -1891,7 +1891,7 @@ heap_insert(Relation relation, HeapTuple tup, CommandId cid, Oid simple_heap_insert(Relation relation, HeapTuple tup) { - return heap_insert(relation, tup, GetCurrentCommandId(), true, true); + return heap_insert(relation, tup, GetCurrentCommandId(true), true, true); } /* @@ -2174,7 +2174,7 @@ simple_heap_delete(Relation relation, ItemPointer tid) result = heap_delete(relation, tid, &update_ctid, &update_xmax, - GetCurrentCommandId(), InvalidSnapshot, + GetCurrentCommandId(true), InvalidSnapshot, true /* wait for commit */ ); switch (result) { @@ -2817,7 +2817,7 @@ simple_heap_update(Relation relation, ItemPointer otid, HeapTuple tup) result = heap_update(relation, otid, tup, &update_ctid, &update_xmax, - GetCurrentCommandId(), InvalidSnapshot, + GetCurrentCommandId(true), InvalidSnapshot, true /* wait for commit */ ); switch (result) { |